Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-693: Support external platform #7442

Merged
merged 3 commits into from Sep 5, 2023
Merged

AGENT-693: Support external platform #7442

merged 3 commits into from Sep 5, 2023

Conversation

pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Aug 22, 2023 •
edited

Support the new external platform type

  • Added external to the supported platforms
  • When platform type is external, only valid platform name is oci
  • Added integration tests for external platform (SNO and Compact)
  • Added additional integration test for invalid network type in case of SNO
  • Updated unit tests for newly added external platform

Signed-off-by: Pawan Pinjarkar ppinjark@redhat.com

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2023 •
edited by openshift-ci bot

@pawanpinjarkar: This pull request references AGENT-693 which is a valid jira issue.

In response to this:

Validate and support the new external platform type

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2023
@pawanpinjarkar
Copy link
Contributor Author

depends on openshift/assisted-service#5438
/hold
/cc @zaneb @andfasano @bfournie

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@pawanpinjarkar
Copy link
Contributor Author

/cc @rwsu

@bfournie
Copy link
Contributor

/retest

@pawanpinjarkar pawanpinjarkar mentioned this pull request Aug 22, 2023
Merged
20 tasks
@pawanpinjarkar pawanpinjarkar force-pushed the external-platform-support-for-ABI branch 2 times, most recently from 9ed8865 to 1d839a5 Compare August 22, 2023 21:43
bfournie added a commit to bfournie/dev-scripts that referenced this pull request Aug 25, 2023
@bfournie
AGENT-698: Agent support for OCI platform
15f9482 
Initial support for the external OCI platform. This sets the libvirt
domain manufacturer and product to allow the assisted-service
validations for this platform to pass.

Requires openshift/assisted-service#5438
and openshift/installer#7442

In addition, this requires changes to either:
a) use a minimalISO instead of a fullISO in the agent-based-installer
b) not require a mimimalISO in assisted-service
@bfournie bfournie mentioned this pull request Aug 25, 2023
Merged
@pawanpinjarkar pawanpinjarkar force-pushed the external-platform-support-for-ABI branch from 09483f9 to ea69a2b Compare August 30, 2023 04:33
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 30, 2023 •
edited by openshift-ci bot

@pawanpinjarkar: This pull request references AGENT-693 which is a valid jira issue.

In response to this:

Support the new external platform type

  • Added external to the supported platforms
  • When platform type is external, only valid platform name is oci
  • Added integration tests for external platform (SNO and Compact)
  • Added additional integration test for invalid network type in case of SNO
  • Updated unit tests for newly added external platform

Signed-off-by: Pawan Pinjarkar ppinjark@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pawanpinjarkar

This comment was marked as duplicate.

Sign in to view

bfournie added a commit to bfournie/dev-scripts that referenced this pull request Aug 30, 2023
@bfournie
AGENT-698: Agent support for OCI platform
2a8d027 
Initial support for the external OCI platform. This sets the libvirt
domain manufacturer and product to allow the assisted-service
validations for this platform to pass.

Requires openshift/assisted-service#5438
and openshift/installer#7442

In addition, this requires changes to either:
a) use a minimalISO instead of a fullISO in the agent-based-installer
b) not require a mimimalISO in assisted-service
@zaneb
Copy link
Member

zaneb commented Aug 31, 2023

This looks good to me as soon as we are able to revendor with openshift/assisted-service#5438

@pawanpinjarkar pawanpinjarkar force-pushed the external-platform-support-for-ABI branch from ea69a2b to ca37ed7 Compare August 31, 2023 19:22
@pawanpinjarkar pawanpinjarkar force-pushed the external-platform-support-for-ABI branch from ca37ed7 to 0c5d73d Compare August 31, 2023 20:10
rwsu
rwsu approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@pawanpinjarkar
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
bfournie added a commit to bfournie/dev-scripts that referenced this pull request Sep 1, 2023
@bfournie
AGENT-698: Agent support for OCI platform
6df610b 
Initial support for the external OCI platform. This sets the libvirt
domain manufacturer and product to allow the assisted-service
validations for this platform to pass.

Requires openshift/assisted-service#5438
and openshift/installer#7442

In addition, this requires changes to either:
a) use a minimalISO instead of a fullISO in the agent-based-installer
b) not require a mimimalISO in assisted-service
bfournie added a commit to bfournie/dev-scripts that referenced this pull request Sep 1, 2023
@bfournie
AGENT-698: Agent support for OCI platform
406723d 
Initial support for the external OCI platform. This sets the libvirt
domain manufacturer and product to allow the assisted-service
validations for this platform to pass.

Requires openshift/assisted-service#5438
and openshift/installer#7442

In addition, this requires changes to either:
a) use a minimalISO instead of a fullISO in the agent-based-installer
b) not require a mimimalISO in assisted-service
@pawanpinjarkar
AGENT-693: Support external platform
7a5b449 
- Added `external` to the supported platforms
- When platform type is `external`, only valid platform name is `oci`
- Added integration tests for external platform (SNO and Compact)
- Added additional integration test for invalid network type in case of SNO
- Updated unit tests for newly added `external` platform

Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Vendor assisted-service using replace directives
ae1be2a 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Fix tests
22b8e9d 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar pawanpinjarkar force-pushed the external-platform-support-for-ABI branch from 2c2439c to 22b8e9d Compare September 5, 2023 14:25
@pawanpinjarkar
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Sep 5, 2023
@bfournie
Copy link
Contributor

bfournie commented Sep 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 186cb91 into openshift:master Sep 5, 2023
27 of 30 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2023

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 22b8e9d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-sno-ipv4-pxe 22b8e9d link false /test e2e-agent-sno-ipv4-pxe

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot pushed a commit to openshift-metal3/dev-scripts that referenced this pull request Sep 8, 2023
@bfournie
AGENT-698: Agent support for OCI platform (#1576)
5cf44c2 
Initial support for the external OCI platform. This sets the libvirt
domain manufacturer and product to allow the assisted-service
validations for this platform to pass.

Requires openshift/assisted-service#5438
and openshift/installer#7442

In addition, this requires changes to either:
a) use a minimalISO instead of a fullISO in the agent-based-installer
b) not require a mimimalISO in assisted-service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneb zaneb zaneb left review comments

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

@celebdor celebdor Awaiting requested review from celebdor

@lranjbar lranjbar Awaiting requested review from lranjbar

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@bfournie bfournie

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pawanpinjarkar @openshift-ci-robot @bfournie @zaneb @rwsu @openshift-merge-robot