Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-19300: Implement workaround to allow SNO installations for OKD/FCOS #7479

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #7445

/assign JM1

OKD/FCOS uses FCOS as its bootimage, i.e. when booting cluster nodes
the first time during installation. FCOS does not provide tools such
as OpenShift Client (oc) or hyperkube which are used during
single-node cluster installation at first boot (e.g. oc in
bootkube.sh [0]). RHCOS and SCOS include these tools, but FCOS has to
pivot the root fs [1] to okd-machine-os [2] first in order to make
those tools available.

Pivoting uses 'rpm-ostree rebase' but during SNO installation the node
will be booted from a FCOS Live ISO where the root fs and /sysroot are
mounted read-only. Thus 'rpm-ostree rebase' fails and necessary tools
for SNO installation will not be available, causing the setup to stall.

This patch works around this issue by mounting /usr and /etc as
overlay filesystems which contains both the content of the live iso as
well as from the okd-machine-os container image.

[0] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template
[1] https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootstrap-pivot.sh.template
[2] https://github.com/openshift/okd-machine-os
@JM1
Copy link
Contributor

JM1 commented Sep 12, 2023

cc @vrutkovs @LorbusChris

@vrutkovs
Copy link
Member

LGTM

@sadasu
Copy link
Contributor

sadasu commented Sep 13, 2023

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@andfasano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@JM1
Copy link
Contributor

JM1 commented Sep 17, 2023

How do we get the missing cherry-pick-approved, jira/valid-bug labels? It looks like i cannot prefix the title “NO-ISSUE:” or “NO-JIRA:” because it was created by a bot :/

@vrutkovs
Copy link
Member

Since 4.15 PR was merged without an issue we'll need to:

  • Create an issue targetting 4.15, close it
  • Create a new one targetting 4.14, link it to the previous one
  • Rename this PR

cherry-pick-approved will be set by staff engineers during periodic review

@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

How can we rename this PR? Is there a cli command for @openshift-cherrypick-robot?

@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

Created https://issues.redhat.com/browse/OCPBUGS-19300 to track this in Jira.

@LorbusChris
Copy link
Member

@JM1 it's /retitle, see also https://prow.ci.openshift.org/command-help / https://prow.k8s.io/command-help

/retitle [release-4.14] OCPBUGS-19300: Implement workaround to allow SNO installations for OKD/FCOS

@openshift-ci openshift-ci bot changed the title [release-4.14] Implement workaround to allow SNO installations for OKD/FCOS [release-4.14] OCPBUGS-19300: Implement workaround to allow SNO installations for OKD/FCOS Sep 18, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19300, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected Jira Issue OCPBUGS-19300 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7445

/assign JM1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 18, 2023
@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@JM1: This pull request references Jira Issue OCPBUGS-19300, which is invalid:

  • expected Jira Issue OCPBUGS-19300 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@JM1: This pull request references Jira Issue OCPBUGS-19300, which is invalid:

  • expected Jira Issue OCPBUGS-19300 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@JM1: This pull request references Jira Issue OCPBUGS-19300, which is invalid:

  • expected Jira Issue OCPBUGS-19300 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JM1
Copy link
Contributor

JM1 commented Sep 18, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 18, 2023
@openshift-ci-robot
Copy link
Contributor

@JM1: This pull request references Jira Issue OCPBUGS-19300, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19299 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19299 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei September 18, 2023 08:10
@gpei
Copy link
Contributor

gpei commented Sep 26, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 0848d80 link false /test okd-scos-e2e-gcp
ci/prow/e2e-aws-ovn-workers-rhel8 0848d80 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-e2e-vsphere 0848d80 link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 0848d80 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-disruptive 0848d80 link false /test e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3b20717 and 2 for PR HEAD 0848d80 in total

@openshift-merge-robot openshift-merge-robot merged commit b1e1cad into openshift:release-4.14 Sep 26, 2023
25 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19300: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19300 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7445

/assign JM1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants