Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15844: Enable FIPS in agent ISO #7540

Merged
merged 2 commits into from Oct 4, 2023
Merged

OCPBUGS-15844: Enable FIPS in agent ISO #7540

merged 2 commits into from Oct 4, 2023

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Sep 29, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 29, 2023
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Jira Issue OCPBUGS-15844, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @bmanzari

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor

I've not been able to deploy a cluster usign the latest 4.15 nightly, but the issue (CrashLoopBack on openshift-ingress) didn't appear to be related to the current patch

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2023
rwsu
rwsu approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.14 nightly worked for me.
/approve since it is targeting 4.14

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2023
@rwsu
Copy link
Contributor

rwsu commented Sep 29, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2023
@andfasano
Copy link
Contributor

/retest-required

@zaneb
Copy link
Member Author

zaneb commented Oct 4, 2023

/retest

@zaneb
Copy link
Member Author

zaneb commented Oct 4, 2023

/retest-required

rwsu
rwsu reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-sno-ipv6 435179f link false /test e2e-agent-sno-ipv6
ci/prow/okd-scos-e2e-agent-sno-ipv6 435179f link false /test okd-scos-e2e-agent-sno-ipv6
ci/prow/e2e-agent-compact-ipv4-appliance 435179f link false /test e2e-agent-compact-ipv4-appliance
ci/prow/okd-e2e-agent-compact-ipv4 435179f link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-e2e-agent-sno-ipv6 435179f link false /test okd-e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 732271d into openshift:master Oct 4, 2023
27 of 32 checks passed
@openshift-ci-robot
Copy link
Contributor

@zaneb: Jira Issue OCPBUGS-15844: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15844 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-10-05-021229

@rwsu rwsu mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu approved these changes

@bmanzari bmanzari Awaiting requested review from bmanzari

@andfasano andfasano Awaiting requested review from andfasano

@lranjbar lranjbar Awaiting requested review from lranjbar

Assignees

@rwsu rwsu

@andfasano andfasano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zaneb @openshift-ci-robot @andfasano @rwsu @openshift-merge-robot