Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: dual stack UPI - create security group rules for IPv6 #7552

Merged
merged 1 commit into from Oct 24, 2023
Merged

openstack: dual stack UPI - create security group rules for IPv6 #7552

merged 1 commit into from Oct 24, 2023

Conversation

gryf
Copy link
Member

@gryf gryf commented Oct 4, 2023

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2023
@gryf gryf marked this pull request as draft October 4, 2023 11:22
@MaysaMacedo
Copy link
Contributor

/cc

@MaysaMacedo
Copy link
Contributor

@gryf Is this PR ready for a look? Will it cover only SGs for now?

@gryf gryf changed the title WIP: Enable UPI dualstack openstack: dual stack UPI - create security group rules for IPv6 Oct 11, 2023
@gryf gryf marked this pull request as ready for review October 11, 2023 08:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023
@gryf
Copy link
Member Author

gryf commented Oct 11, 2023

@MaysaMacedo yes, it's ready for review.

@openshift-ci openshift-ci bot requested a review from mandre October 11, 2023 08:06
MaysaMacedo
MaysaMacedo reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@MaysaMacedo MaysaMacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include the following rules for master?
https://github.com/openshift/installer/blob/master/data/data/openstack/masters/sg-master.tf#L524-L546

I know that we don't have the respective of that for IPv4 in UPI, but that is a bug and I will propose a separate fix for it.

upi/openstack/security-groups.yaml Outdated Show resolved Hide resolved
mandre
mandre reviewed Oct 16, 2023
View reviewed changes
upi/openstack/security-groups.yaml Outdated
@@ -63,13 +63,55 @@
port_range_min: 53
port_range_max: 53

- name: 'Create master-sg rule "Ingress HTTP"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rules, for master should be conditional to the fact that masters are schedulable. Discussion is happening in #7576.

Let's first resolve the compact cluster case in in #7576, before adding the rules for IPv6.
@MaysaMacedo, would that work for you?

@MaysaMacedo
Copy link
Contributor

/lgtm
/approve

Let's handle the other SGs for compact clusters with IPv6 once the other PR merges

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d34d54e and 2 for PR HEAD b4b35ba in total

mandre
mandre reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@gryf
Copy link
Member Author

gryf commented Oct 23, 2023

/retest-required

@gryf gryf force-pushed the upi-ds branch 2 times, most recently from b59dc9d to f922b66 Compare October 24, 2023 09:15
mandre
mandre reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2023
@gryf
Copy link
Member Author

gryf commented Oct 24, 2023

/retest-required

@MaysaMacedo
Copy link
Contributor

/lgtm
/hold cancel
we already got Martin's lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2023

@gryf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-intel d2434f5 link false /test e2e-openstack-nfv-intel
ci/prow/e2e-openstack-upi d2434f5 link false /test e2e-openstack-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 5d0755f into openshift:master Oct 24, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@EmilienM EmilienM Awaiting requested review from EmilienM

@stephenfin stephenfin Awaiting requested review from stephenfin

Assignees

@mandre mandre

@MaysaMacedo MaysaMacedo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gryf @MaysaMacedo @openshift-ci-robot @mandre