Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: cmd/openshift-install: Remove "migrate" command #7601

Merged
merged 2 commits into from Nov 28, 2023
Merged

no-jira: cmd/openshift-install: Remove "migrate" command #7601

merged 2 commits into from Nov 28, 2023

Conversation

jhixson74
Copy link
Member

The migrate command migrated old style Azure DNS zones to the newer style. The ability to create old style DNS zones in Azure hasn't existed in years, so this command can be retired.

@openshift-ci openshift-ci bot requested review from bfournie and rwsu October 18, 2023 01:30
@sadasu
Copy link
Contributor

sadasu commented Oct 26, 2023

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Oct 27, 2023

/test verify-vendor

Afaik, failure does not seem related to this change.

@jhixson74
Copy link
Member Author

/test gofmt
/test tf-lint
/test unit
/test verify-codegen
/test verify-vendor
/test e2e-aws-ovn

@jhixson74 jhixson74 changed the title cmd/openshift-install: Remove "migrate" command no-jira: cmd/openshift-install: Remove "migrate" command Nov 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2023
@openshift-ci-robot
Copy link
Contributor

@jhixson74: This pull request explicitly references no jira issue.

In response to this:

The migrate command migrated old style Azure DNS zones to the newer style. The ability to create old style DNS zones in Azure hasn't existed in years, so this command can be retired.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4
r4f4 reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@r4f4
Copy link
Contributor

r4f4 commented Nov 23, 2023

/lgtm cancel
Needs go mod tidy && go mod vendor

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
@jhixson74
cmd/openshift-install: Remove "migrate" command
e45f862 
The migrate command migrated old style Azure DNS zones to the newer
style. The ability to create old style DNS zones in Azure hasn't existed
in years, so this command can be retired.
@jhixson74
go mod tidy & go mod vendor
e969e7b
@jhixson74
Copy link
Member Author

/lgtm cancel Needs go mod tidy && go mod vendor

Updated.

r4f4
r4f4 reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see +0 −68,776
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 25, 2023

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc e969e7b link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack e969e7b link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhixson74
Copy link
Member Author

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit d7380b6 into openshift:master Nov 28, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@bfournie bfournie Awaiting requested review from bfournie

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhixson74 @sadasu @openshift-ci-robot @r4f4