Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-21653: Rectify GCP label key validation check #7606

Merged
merged 1 commit into from Oct 31, 2023
Merged

[release-4.14] OCPBUGS-21653: Rectify GCP label key validation check #7606

merged 1 commit into from Oct 31, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7596

/assign bharath-b-rh

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21781 has been cloned as Jira Issue OCPBUGS-21884. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-21884: Rectify GCP label key validation check

In response to this:

This is an automated cherry-pick of #7596

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-21781: Rectify GCP label key validation check [release-4.14] OCPBUGS-21884: Rectify GCP label key validation check Oct 18, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21884, which is invalid:

  • expected dependent Jira Issue OCPBUGS-21781 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7596

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gpei
Copy link
Contributor

gpei commented Oct 19, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 19, 2023
@jhixson74
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@bharath-b-rh
Copy link
Contributor

/jira OCPBUGS-21653

@bharath-b-rh
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bharath-b-rh: This pull request references Jira Issue OCPBUGS-21884, which is invalid:

  • expected Jira Issue OCPBUGS-21884 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bharath-b-rh: This pull request references Jira Issue OCPBUGS-21884, which is invalid:

  • expected Jira Issue OCPBUGS-21884 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@bharath-b-rh: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bharath-b-rh: This pull request references Jira Issue OCPBUGS-21884, which is invalid:

  • expected Jira Issue OCPBUGS-21884 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Oct 19, 2023

/retitle [release-4.14] OCPBUGS-21653: Rectify GCP label key validation check

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-21884: Rectify GCP label key validation check [release-4.14] OCPBUGS-21653: Rectify GCP label key validation check Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-21653, which is invalid:

  • expected dependent Jira Issue OCPBUGS-21781 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7596

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh
Copy link
Contributor

/cc @patrickdillon @sadasu

@openshift-ci openshift-ci bot requested a review from sadasu October 19, 2023 08:00
@sadasu
Copy link
Contributor

sadasu commented Oct 19, 2023

/label backport-risk-assessed

@sadasu
Copy link
Contributor

sadasu commented Oct 19, 2023

/jira refresh

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@sadasu: This pull request references Jira Issue OCPBUGS-21653, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21781 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-21781 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianli-wei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 19, 2023
@bharath-b-rh
Copy link
Contributor

/retest-required

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 31, 2023
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 31, 2023 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere fe93c04 link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp-ovn-upgrade fe93c04 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-gcp fe93c04 link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-aws-upgrade fe93c04 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn-upgrade fe93c04 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 03546e5 and 2 for PR HEAD fe93c04 in total

@openshift-ci openshift-ci bot merged commit 1b4f17c into openshift:release-4.14 Oct 31, 2023
26 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-21653: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21653 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7596

/assign bharath-b-rh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 3, 2023
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-11-03-193211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rwsu rwsu Awaiting requested review from rwsu

@sadasu sadasu Awaiting requested review from sadasu

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

Assignees

@jhixson74 jhixson74

@bharath-b-rh bharath-b-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @gpei @jhixson74 @bharath-b-rh @r4f4 @sadasu @openshift-merge-robot