Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-22116: Add KMS encryption keys if provided #7612

Closed
wants to merge 1 commit into from
Closed

[release-4.12] OCPBUGS-22116: Add KMS encryption keys if provided #7612

wants to merge 1 commit into from

Conversation

pawanpinjarkar
Copy link
Contributor

This is a manual cherry-pick of #7428

/assign pawanpinjarkar

@pawanpinjarkar
OCPBUGS-13664: Add KMS encryption keys if provided
26cdff7 
Add KMS encryption keys if provided either
in master machine pool or in aws machine pool

Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-22090, which is invalid:

  • expected the bug to target the "4.12.z" version, but it targets "4.14.0" instead
  • expected dependent Jira Issue OCPBUGS-13664 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-13664 to target a version in 4.13.0, 4.13.z, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #7428

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar pawanpinjarkar changed the title [release-4.12] OCPBUGS-22090: Add KMS encryption keys if provided [release-4.12] OCPBUGS-22116: Add KMS encryption keys if provided Oct 19, 2023
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-22116, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13664 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-13664 to target a version in 4.13.0, 4.13.z, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #7428

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pawanpinjarkar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-22116, which is invalid:

  • expected dependent Jira Issue OCPBUGS-13664 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-13664 to target a version in 4.13.0, 4.13.z, but it targets "4.15.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-disruptive 26cdff7 link false /test e2e-aws-ovn-disruptive
ci/prow/okd-e2e-aws-ovn-upgrade 26cdff7 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-compact 26cdff7 link true /test e2e-agent-compact
ci/prow/e2e-aws-ovn-single-node 26cdff7 link false /test e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-upgrade 26cdff7 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn 26cdff7 link false /test okd-e2e-aws-ovn
ci/prow/e2e-crc 26cdff7 link false /test e2e-crc
ci/prow/okd-scos-e2e-aws-ovn 26cdff7 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-fips 26cdff7 link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-shared-vpc 26cdff7 link false /test e2e-aws-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Oct 23, 2023

/hold
See https://issues.redhat.com/browse/OCPBUGS-22231

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@dgoodwin
Copy link
Contributor

/hold

1 similar comment
@pawanpinjarkar
Copy link
Contributor Author

/hold

@pawanpinjarkar
Copy link
Contributor Author

/close

@openshift-ci openshift-ci bot closed this Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-22116. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

This is a manual cherry-pick of #7428

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@pawanpinjarkar: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@pawanpinjarkar pawanpinjarkar

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pawanpinjarkar @openshift-ci-robot @r4f4 @dgoodwin