New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-2852: Introduce pkg/clusterapi, system, and local control plane #7630
Conversation
@@ -0,0 +1,251 @@ | |||
package process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package and sub-packages are adapted from Controller Runtime
954c7bf
to
adfa99f
Compare
/test golint |
016aca5
to
4b5f714
Compare
c14a6e3
to
976e77e
Compare
@vincepri: This pull request references CORS-2852 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/skip |
/refresh |
/override verify-codegen |
/skip |
@vincepri: vincepri unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Why would you override this test? |
/override ci/prow/altinfra-images |
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/altinfra-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
+1 we shouldn't override that test, but I think that test may have been selected randomly. It looks like the prow status for this pr is broken: https://prow.ci.openshift.org/pr?query=is%3Apr+repo%3Aopenshift%2Finstaller+author%3Avincepri+head%3Acapi-system |
/test ci/prow/okd-images |
@patrickdillon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
oh right, of course we have different syntax requirements between override and test /test okd-images |
You might have to contact the test platform team. This job run claims to be running for 24h+ so maybe new jobs won't be triggered https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7630/pull-ci-openshift-installer-master-okd-images/1719371255477440512 |
Was just testing because everything seemed stuck. |
Signed-off-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Vince Prignano <vincepri@redhat.com>
…tomer key Signed-off-by: Vince Prignano <vincepri@redhat.com>
/test e2e-azurestack |
/skip |
/lgtm |
@vincepri: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Builds on top of
#7620