Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2852: Introduce pkg/clusterapi, system, and local control plane #7630

Merged
merged 4 commits into from Nov 2, 2023

Conversation

vincepri
Copy link
Contributor

Builds on top of

#7620

@@ -0,0 +1,251 @@
package process
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package and sub-packages are adapted from Controller Runtime

@vincepri
Copy link
Contributor Author

/test golint

@vincepri vincepri force-pushed the capi-system branch 4 times, most recently from 016aca5 to 4b5f714 Compare October 27, 2023 14:57
hack/build-cluster-api.sh Show resolved Hide resolved
pkg/clusterapi/README.md Outdated Show resolved Hide resolved
pkg/clusterapi/system.go Outdated Show resolved Hide resolved
@vincepri vincepri force-pushed the capi-system branch 3 times, most recently from c14a6e3 to 976e77e Compare October 30, 2023 18:35
@vincepri vincepri changed the title Introduce pkg/clusterapi, system, and local control plane CORS-2852: Introduce pkg/clusterapi, system, and local control plane Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 30, 2023

@vincepri: This pull request references CORS-2852 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Builds on top of

#7620

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2023
@vincepri
Copy link
Contributor Author

vincepri commented Nov 1, 2023

/skip

@patrickdillon
Copy link
Contributor

/refresh

@vincepri
Copy link
Contributor Author

vincepri commented Nov 1, 2023

/override verify-codegen

@patrickdillon
Copy link
Contributor

/skip

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@vincepri: vincepri unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override verify-codegen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Nov 1, 2023

/override verify-codegen

Why would you override this test?

@patrickdillon
Copy link
Contributor

/override ci/prow/altinfra-images

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/altinfra-images

In response to this:

/override ci/prow/altinfra-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/override verify-codegen

Why would you override this test?

+1 we shouldn't override that test, but I think that test may have been selected randomly. It looks like the prow status for this pr is broken: https://prow.ci.openshift.org/pr?query=is%3Apr+repo%3Aopenshift%2Finstaller+author%3Avincepri+head%3Acapi-system

@patrickdillon
Copy link
Contributor

/test ci/prow/okd-images
/test ci/prow/okd-scos-images
/test ci/prow/okd-verify-codegen
/test ci/prow/verify-codegen

Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@patrickdillon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-localzones
  • /test altinfra-e2e-azure-ovn
  • /test altinfra-e2e-azure-ovn-resourcegroup
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-alibaba
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-localzones
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-localzones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack-techpreview
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test e2e-vsphere-zones-techpreview
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-agent-compact-ipv4
  • /test okd-scos-e2e-agent-sno-ipv6
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-custom-security-groups
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-fips
  • pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-ovn-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp-ovn
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-xpn
  • pull-ci-openshift-installer-master-e2e-gcp-secureboot
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test ci/prow/okd-images
/test ci/prow/okd-scos-images
/test ci/prow/okd-verify-codegen
/test ci/prow/verify-codegen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

oh right, of course we have different syntax requirements between override and test

/test okd-images
/test okd-scos-images
/test okd-verify-codegen
/test verify-codegen

@r4f4
Copy link
Contributor

r4f4 commented Nov 1, 2023

You might have to contact the test platform team. This job run claims to be running for 24h+ so maybe new jobs won't be triggered https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_installer/7630/pull-ci-openshift-installer-master-okd-images/1719371255477440512

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 43a82ab and 2 for PR HEAD abdc4e1 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c59a824 and 1 for PR HEAD abdc4e1 in total

@vincepri
Copy link
Contributor Author

vincepri commented Nov 1, 2023

/override verify-codegen

Why would you override this test?

Was just testing because everything seemed stuck.

Signed-off-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Vince Prignano <vincepri@redhat.com>
Signed-off-by: Vince Prignano <vincepri@redhat.com>
…tomer key

Signed-off-by: Vince Prignano <vincepri@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@vincepri
Copy link
Contributor Author

vincepri commented Nov 1, 2023

/test e2e-azurestack

@patrickdillon
Copy link
Contributor

/skip

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c59a824 and 2 for PR HEAD d27acf3 in total

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

@vincepri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 976e77e link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 976e77e link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade d27acf3 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-ovn-xpn d27acf3 link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-aws-ovn-localzones d27acf3 link false /test e2e-aws-ovn-localzones
ci/prow/e2e-aws-ovn-shared-vpc-localzones d27acf3 link false /test e2e-aws-ovn-shared-vpc-localzones
ci/prow/e2e-azurestack d27acf3 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants