[release-4.14] OCPBUGS-22770: destroy: gcp: fix destroying regional disks #7657
Conversation
Regional disks are replicated in multiple zones but our logic was not
taking them into account, only zonal disks. When trying to run `cluster
destroy` in a cluster with regional disks, the following panic was
observed:
```
time="2023-07-25T10:02:16Z" level=debug msg="Found disk: pvc-c8cf8f18-cd22-441e-b47a-565bed5573ee in zone europe-west2-a"
time="2023-07-25T10:02:16Z" level=debug msg="Found disk: pvc-3e703665-2271-4c16-8bf8-533b5e7be444 in zone "
E0725 10:02:16.633982 1 runtime.go:79] Observed a panic: runtime.boundsError{x:-1, y:0, signed:true, code:0x1} (runtime error: slice bounds out of range [:-1])
goroutine 1 [running]:
[k8s.io/apimachinery/pkg/util/runtime.logPanic(
{0x7b0e040|http://k8s.io/apimachinery/pkg/util/runtime.logPanic(%7B0x7b0e040]?, 0xc00007dde8}
)
k8s.io/apimachinery@v0.24.1/pkg/util/runtime/runtime.go:75 +0x99
[k8s.io/apimachinery/pkg/util/runtime.HandleCrash(
{0x0|http://k8s.io/apimachinery/pkg/util/runtime.HandleCrash(%7B0x0], 0x0, 0xc000120260?}
)
k8s.io/apimachinery@v0.24.1/pkg/util/runtime/runtime.go:49 +0x75
panic({0x7b0e040, 0xc00007dde8})
runtime/panic.go:884 +0x212
github.com/openshift/installer/pkg/destroy/gcp.getRegionFromZone(...)
github.com/openshift/installer@v0.9.0-master.0.20220901213408-25aa6a41b7ca/pkg/destroy/gcp/gcp.go:204
github.com/openshift/installer/pkg/destroy/gcp.(*ClusterUninstaller).listDisksWithFilter.func1(0xc00165eec0?)
```
This fix includes logic to deal with finding the replicated zones and
deleting the disks in all of them.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-22489 has been cloned as Jira Issue OCPBUGS-22770. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22770, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.13 |
|
@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@jianli-wei: This pull request references Jira Issue OCPBUGS-22770, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/lgtm |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22770, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/assign @sadasu |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test okd-scos-images |
openshift-merge-bot
bot
merged commit 5fd7986
into
openshift:release-4.14
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-22770: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22770 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@r4f4: new pull request created: #7840 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-baremetal-installer-container-v4.14.0-202312141848.p0.g5fd7986.assembly.stream for distgit ose-baremetal-installer. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-12-15-025512 |
This is an automated cherry-pick of #7643
/assign r4f4