Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-22771: aws: use security groups from defaultMachinePlatform #7658

Merged
merged 1 commit into from Dec 18, 2023
Merged

[release-4.14] OCPBUGS-22771: aws: use security groups from defaultMachinePlatform #7658

merged 1 commit into from Dec 18, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7589

/assign r4f4

@r4f4
OCPBUGS-20525: aws: use security groups from defaultMachinePlatform
089e213 
If no additionalSecurityGroupIDs is specified for controlPlane, make
sure that additionalSecurityGroupIDs from  defaultMachinePlatform is
used instead.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-20525 has been cloned as Jira Issue OCPBUGS-22771. Will retitle bug to link to clone.
/retitle [release-4.14] OCPBUGS-22771: aws: use security groups from defaultMachinePlatform

In response to this:

This is an automated cherry-pick of #7589

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-20525: aws: use security groups from defaultMachinePlatform [release-4.14] OCPBUGS-22771: aws: use security groups from defaultMachinePlatform Oct 31, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 31, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22771, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20525 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20525 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7589

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 089e213 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 089e213 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-vsphere 089e213 link false /test okd-scos-e2e-vsphere
ci/prow/e2e-aws-ovn-workers-rhel8 089e213 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-e2e-gcp 089e213 link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-aws-upgrade 089e213 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 089e213 link false /test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Dec 4, 2023

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@patrickdillon
Copy link
Contributor

/label backport-risk-assessed
/lgtm

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 15, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@gpei
Copy link
Contributor

gpei commented Dec 18, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 18, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit a3cbb19 into openshift:release-4.14 Dec 18, 2023
22 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-22771: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22771 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7589

/assign r4f4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-container-v4.14.0-202312180653.p0.ga3cbb19.assembly.stream for distgit ose-installer.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-12-18-150105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpei gpei Awaiting requested review from gpei

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@r4f4 r4f4

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @r4f4 @patrickdillon @gpei @openshift-bot @openshift-merge-robot