Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2428: images: add Dockerfile for a terraform-providers image #7687

Merged
merged 1 commit into from Nov 8, 2023

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Nov 6, 2023

This Dockerfile will build the terraform provider binaries for all platforms/arches needed by the Installer images. Reusing this container in CI should stop the terraform provider binaries from being built every time there is a change to the Installer repo, since the providers are changed very sparingly.

This Dockerfile will build the terraform provider binaries for all
platforms/arches needed by the Installer images. Reusing this container
in CI should stop the terraform provider binaries from being built every
time there is a change to the Installer repo, since the providers are
changed very sparingly.
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 6, 2023

Once this merges, I'll reopen openshift/release#39563 and change the code to use the Dockerfile from this PR.

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 6, 2023

/cc @zaneb @patrickdillon

@zaneb
Copy link
Member

zaneb commented Nov 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@patrickdillon
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 8, 2023

/rename CORS-2428: images: add Dockerfile for a terraform-providers image

@patrickdillon patrickdillon changed the title images: add Dockerfile for a terraform-providers image CORS-2428: images: add Dockerfile for a terraform-providers image Nov 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2023

@r4f4: This pull request references CORS-2428 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

This Dockerfile will build the terraform provider binaries for all platforms/arches needed by the Installer images. Reusing this container in CI should stop the terraform provider binaries from being built every time there is a change to the Installer repo, since the providers are changed very sparingly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 973140b into openshift:master Nov 8, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants