Bug OCPBUGS-19462: OpenStack: Fix dual-stack machines Spec to contain network #7694
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
When the network ID or Name is not specified in the `controlPlanePort` field, MAPO would create one Port per Subnet. In dual-stack clusters we must have one unique dual-stack Port. This commit fixes the issue by discovering the network ID from one of the subnets and adding it to the Machine Spec.
MaysaMacedo
force-pushed
the
fix-machines-generation
branch
from
a6d6ccf
to
5207119
Compare
There was a problem hiding this comment.
I think that no matter what we decide to do with openshift/machine-api-provider-openstack#92, we still want to be explicit in the installer and request the creation of a unique port for dual-stack.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
MaysaMacedo
changed the title
openshift-ci-robot
added
jira/severity-low
|
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-19462, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@MaysaMacedo: This pull request references Jira Issue OCPBUGS-19462, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@MaysaMacedo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@MaysaMacedo: Jira Issue OCPBUGS-19462: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-19462 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-baremetal-installer-container-v4.15.0-202311130831.p0.g898c5e4.assembly.stream for distgit ose-baremetal-installer. |
|
/cherry-pick release-4.14 |
|
@MaysaMacedo: new pull request created: #7713 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When the network ID or Name is not specified in the
controlPlanePortfield, MAPO would create one Port per Subnet. In dual-stack clusters we must have one unique dual-stack Port. This commit fixes the issue by discovering the network ID from one of the subnets and adding it to the Machine Spec.