Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSASINFRA-3294: OpenStack: fix script to update bootstrap ignition shim #7743

Merged
merged 1 commit into from Nov 21, 2023
Merged

OSASINFRA-3294: OpenStack: fix script to update bootstrap ignition shim #7743

merged 1 commit into from Nov 21, 2023

Conversation

MaysaMacedo
Copy link
Contributor

This commit removes undefined variable from the script that adds the certificate to the bootstrap ignition shim.

@MaysaMacedo
OpenStack: fix script to update bootstrap ignition shim
f1bbaa3 
This commit removes undefined variable from the script that
adds the certificate to the bootstrap ignition shim and removes
unecessary comma.
@MaysaMacedo MaysaMacedo force-pushed the fix-bootstrap-ignition-shim-script branch from b880c81 to f1bbaa3 Compare November 19, 2023 19:19
@MaysaMacedo
Copy link
Contributor Author

/cc @gryf

@openshift-ci openshift-ci bot requested a review from gryf November 20, 2023 13:40
gryf
gryf approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@gryf gryf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gryf
Copy link
Member

gryf commented Nov 20, 2023

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. lgtm Indicates that a PR is ready to be merged. labels Nov 20, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gryf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@MaysaMacedo MaysaMacedo changed the title OpenStack: fix script to update bootstrap ignition shim OSASINFRA-3294: OpenStack: fix script to update bootstrap ignition shim Nov 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 21, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 21, 2023 •
edited by openshift-ci bot

@MaysaMacedo: This pull request references OSASINFRA-3294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This commit removes undefined variable from the script that adds the certificate to the bootstrap ignition shim.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023 •
edited

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy f1bbaa3 link false /test e2e-openstack-proxy
ci/prow/e2e-openstack-sdn-parallel f1bbaa3 link false /test e2e-openstack-sdn-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1bacadd and 2 for PR HEAD f1bbaa3 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 7956adb into openshift:master Nov 21, 2023
13 of 15 checks passed
@MaysaMacedo MaysaMacedo deleted the fix-bootstrap-ignition-shim-script branch November 22, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gryf gryf gryf approved these changes

@EmilienM EmilienM Awaiting requested review from EmilienM

@mandre mandre Awaiting requested review from mandre

Assignees

@gryf gryf

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaysaMacedo @gryf @openshift-ci-robot