Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24026: Add owner for user provided client CA bundle #7749

Merged
merged 2 commits into from Nov 28, 2023
Merged

OCPBUGS-24026: Add owner for user provided client CA bundle #7749

merged 2 commits into from Nov 28, 2023

Conversation

vrutkovs
Copy link
Member

Reroll of #7742 with proper api bump

@vrutkovs vrutkovs changed the title Add owner for user provided client CA bundle WIP Add owner for user provided client CA bundle Nov 21, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@vrutkovs vrutkovs changed the title WIP Add owner for user provided client CA bundle Add owner for user provided client CA bundle Nov 22, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@deads2k @vrutkovs
Add owner for user provided client CA bundle
3226648 
This is provided by the customer, so they own the content.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023 •
edited

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack f0fb7f6 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-shared-vpc-localzones f0fb7f6 link false /test e2e-aws-ovn-shared-vpc-localzones
ci/prow/e2e-gcp-secureboot f0fb7f6 link false /test e2e-gcp-secureboot
ci/prow/openstack-manifests f0fb7f6 link true /test openstack-manifests
ci/prow/e2e-gcp-ovn f0fb7f6 link true /test e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-shared-vpc f0fb7f6 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-gcp-ovn-xpn f0fb7f6 link false /test e2e-gcp-ovn-xpn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs changed the title Add owner for user provided client CA bundle OCPBUGS-24026: Add owner for user provided client CA bundle Nov 28, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 28, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-24026, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reroll of #7742 with proper api bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei November 28, 2023 15:56
@patrickdillon
Copy link
Contributor

/approve
/lgtm

@patrickdillon patrickdillon mentioned this pull request Nov 28, 2023
Closed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 114c291 into openshift:master Nov 28, 2023
22 checks passed
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Jira Issue OCPBUGS-24026: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24026 has been moved to the MODIFIED state.

In response to this:

Reroll of #7742 with proper api bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2023-12-02-123536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@gpei gpei Awaiting requested review from gpei

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vrutkovs @openshift-ci-robot @patrickdillon @openshift-merge-robot @deads2k