Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULTIARCH-4041: Power VS: Transition to ibm_pi_workspace instead of resource_instance #7785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjturek
Copy link
Contributor

@mjturek mjturek commented Nov 30, 2023

resource_instance is being deprecated for power_iaas in favor of the new ibm_pi_workspace resource. Use this new resource instead.

Requires #7784

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

data/data/powervs/cluster/iaas/iaas.tf Outdated Show resolved Hide resolved
@AshwinHIBM
Copy link
Contributor

cloud_instance_id = module.iaas.si_guid

cloud_instance_id     = module.iaas.pi_workspace_id

@mjturek mjturek changed the title Power VS: Transition to ibm_pi_workspace instead of resource_instance MULTIARCH-4041: Power VS: Transition to ibm_pi_workspace instead of resource_instance Dec 1, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 1, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2023

@mjturek: This pull request references MULTIARCH-4041 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

resource_instance is being deprecated for power_iaas in favor of the new ibm_pi_workspace resource. Use this new resource instead.

Requires #7784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

resource_instance is being deprecated for power_iaas in favor of
the new ibm_pi_workspace resource. Use this new resource instead.
@mjturek
Copy link
Contributor Author

mjturek commented Dec 2, 2023

/retest

@mjturek
Copy link
Contributor Author

mjturek commented Dec 2, 2023

/test e2e-aws-ovn

@mjturek
Copy link
Contributor Author

mjturek commented Dec 2, 2023

/test golint

@AshwinHIBM
Copy link
Contributor

/test e2e-aws-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AshwinHIBM
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2023
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

@mjturek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 5634eb0 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 5634eb0 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/altinfra-openstack-capi-manifests 5634eb0 link true /test altinfra-openstack-capi-manifests
ci/prow/altinfra-periodics-images 5634eb0 link true /test altinfra-periodics-images
ci/prow/e2e-agent-compact-ipv4 5634eb0 link true /test e2e-agent-compact-ipv4
ci/prow/agent-integration-tests 5634eb0 link true /test agent-integration-tests
ci/prow/e2e-vsphere-ovn-upi 5634eb0 link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants