New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-2952: GCP Set "ClusterHostedDNS" in the Infra CR based on the value of userProvisionedDNS #7796
Conversation
@sadasu: This pull request references CORS-2952 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dcfb881
to
956410a
Compare
/jira refresh |
@sadasu: This pull request references CORS-2952 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
When userProvisionedDNS is enabled on GCP, set `ClusterHostedDNS` in the GCP PlatformStatus of the Infra CR to Enabled.
Add validation to make sure that feature gate is enabled when the feature is enabled.
/lgtm |
@sadasu: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
29341ee
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312071150.p0.g29341ee.assembly.stream for distgit ose-installer-altinfra. |
ClusterHostedDNS
field within the GCP PlatformStatus of the Infra CR.userProvisionedDNS
on GCP, via install-config, setClusterHostedDNS
within the GCP PlatformStatus to Enabled.userProvisionedDNS
can be enabled only when theGCPClusterHostedDNS
feature gate is enabled.