Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2952: GCP Set "ClusterHostedDNS" in the Infra CR based on the value of userProvisionedDNS #7796

Merged
merged 2 commits into from Dec 7, 2023

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Dec 4, 2023

  1. Pull in the openshift/api changes that introduce theClusterHostedDNS field within the GCP PlatformStatus of the Infra CR.
  2. When the user enables userProvisionedDNS on GCP, via install-config, set ClusterHostedDNS within the GCP PlatformStatus to Enabled.
  3. Make sure that userProvisionedDNS can be enabled only when the GCPClusterHostedDNS feature gate is enabled.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 4, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@sadasu: This pull request references CORS-2952 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

  1. Pull in the openshift/api changes that introduce theClusterHostedDNS field within the GCP PlatformStatus of the Infra CR.
  2. When the user enables userProvisionedDNS on GCP, via install-config, set ClusterHostedDNS within the GCP PlatformStatus to Enabled.
  3. Make sure that userProvisionedDNS can be enabled only when the GCPClusterHostedDNS feature gate is enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Contributor Author

sadasu commented Dec 4, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 4, 2023

@sadasu: This pull request references CORS-2952 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Contributor Author

sadasu commented Dec 4, 2023

/retest-required

@jhixson74
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2023
@sadasu
Copy link
Contributor Author

sadasu commented Dec 4, 2023

/approve

Copy link
Contributor

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@jhixson74
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8c267fd and 2 for PR HEAD 77effad in total

When userProvisionedDNS is enabled on GCP, set `ClusterHostedDNS`
in the GCP PlatformStatus of the Infra CR to Enabled.
Add validation to make sure that feature gate is enabled when the
feature is enabled.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@jhixson74
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

@sadasu: you cannot LGTM your own PR.

In response to this:

/lgtm

Lost lgmt after rebase and for reason the one above is not taking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link
Contributor

openshift-ci bot commented Dec 7, 2023

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 5d4297a link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-gcp-secureboot 5d4297a link false /test e2e-gcp-secureboot

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 29341ee into openshift:master Dec 7, 2023
24 of 26 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312071150.p0.g29341ee.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants