OCPBUGS-23140, OCPBUGS-23305: Soften VIP validations for external load-balancer #7803
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@mkowalski: This pull request references Jira Issue OCPBUGS-23305, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@mkowalski: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test gofmt |
…d-balancer Currently for cluster-managed load balancer we have a set of validations ensuring that API and Ingress VIP are placed in a correct subnet as well as they do not overlap. For user-managed load balancer those validations are too strong as customers may have external load balancers placed outside of networks where cluster nodes live. Similarly, they may reuse the same IP for API and Ingress VIP, and distribute traffic via other means (e.g. using the port for the connection). With this PR we are softening the validations if the configuration used is indicating that external load balancer is used. Closes: OCPBUGS-23140 Closes: OCPBUGS-23305
mkowalski
force-pushed
the
OCPBUGS-23140
branch
from
02a150e
to
e2eb847
Compare
|
/test gofmt |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
/skip |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mkowalski: Jira Issue OCPBUGS-23305: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23305 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312070751.p0.g1870993.assembly.stream for distgit ose-installer-altinfra. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-07-225558 |
Currently for cluster-managed load balancer we have a set of validations ensuring that API and Ingress VIP are placed in a correct subnet as well as they do not overlap.
For user-managed load balancer those validations are too strong as customers may have external load balancers placed outside of networks where cluster nodes live. Similarly, they may reuse the same IP for API and Ingress VIP, and distribute traffic via other means (e.g. using the port for the connection).
With this PR we are softening the validations if the configuration used is indicating that external load balancer is used.
Closes: OCPBUGS-23140
Closes: OCPBUGS-23305