Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3003: [ibmcloud] add key-protect plugin in ibmcloud cli #7811

Merged
merged 1 commit into from Dec 11, 2023
Merged

CORS-3003: [ibmcloud] add key-protect plugin in ibmcloud cli #7811

merged 1 commit into from Dec 11, 2023

Conversation

MayXuQQ
Copy link
Contributor

@MayXuQQ MayXuQQ commented Dec 7, 2023 •
edited by openshift-ci bot

CORS-3003 CI implementation: Review and support the work from IBM to enable BYOK in OpenShift on IBM Cloud VPC

@openshift-ci openshift-ci bot requested review from jhixson74 and rwsu December 7, 2023 17:17
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Dec 8, 2023

/retest-required

@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Dec 8, 2023

/assign @jianlinliu

@jianlinliu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Dec 8, 2023

/assign @jhixson74

@jianlinliu
Copy link
Contributor

cc @r4f4 to review.

r4f4
r4f4 reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@jianlinliu
Copy link
Contributor

tide Pending — Not mergeable. Needs jira/valid-reference labels.

I think you need a jira issue to associate with this PR.

@r4f4
Copy link
Contributor

r4f4 commented Dec 8, 2023

tide Pending — Not mergeable. Needs jira/valid-reference labels.

I think you need a jira issue to associate with this PR.

Will this be backported? If not, we don't need a Jira.

@r4f4
Copy link
Contributor

r4f4 commented Dec 8, 2023 •
edited by openshift-ci bot

/retitle CORS-3003: [ibmcloud] add key-protect plugin in ibmcloud cli

@openshift-ci openshift-ci bot changed the title [ibmcloud] CORS-3003 add key-protect plugin in ibmcloud cli CORS-3003: [ibmcloud] add key-protect plugin in ibmcloud cli Dec 8, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 8, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 8, 2023 •
edited by openshift-ci bot

@MayXuQQ: This pull request references CORS-3003 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

CORS-3003 CI implementation: Review and support the work from IBM to enable BYOK in OpenShift on IBM Cloud VPC

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianlinliu
Copy link
Contributor

Will this be backported? If not, we don't need a Jira.

Thanks for the retitle, I guess we do not need to backport it.

@jianlinliu
Copy link
Contributor

/test altinfra-e2e-aws-ovn-upi

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 46fd662 and 2 for PR HEAD 015ade4 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e44ef17 and 1 for PR HEAD 015ade4 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0de586a and 0 for PR HEAD 015ade4 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 015ade4 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@MayXuQQ
Copy link
Contributor Author

MayXuQQ commented Dec 11, 2023

/retest-required

@r4f4
Copy link
Contributor

r4f4 commented Dec 11, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2023
@r4f4
Copy link
Contributor

r4f4 commented Dec 11, 2023

/override ci/prow/e2e-azure-ovn-upi ci/prow/e2e-gcp-ovn-upi ci/prow/altinfra-e2e-aws-ovn-upi
e2e test failures unrelated to PR

/override ci/prow/e2e-vsphere-upi-zones
Job looks broken with invalid terraform arguments

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/altinfra-e2e-aws-ovn-upi, ci/prow/e2e-azure-ovn-upi, ci/prow/e2e-gcp-ovn-upi, ci/prow/e2e-vsphere-upi-zones

In response to this:

/override ci/prow/e2e-azure-ovn-upi ci/prow/e2e-gcp-ovn-upi ci/prow/altinfra-e2e-aws-ovn-upi
e2e test failures unrelated to PR

/override ci/prow/e2e-vsphere-upi-zones
Job looks broken with invalid terraform arguments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0de586a and 2 for PR HEAD 015ade4 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023 •
edited

@MayXuQQ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 015ade4 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor

r4f4 commented Dec 11, 2023

/override ci/prow/e2e-aws-ovn-upi
e2e failures unrelated to PR changes.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2023

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn-upi

In response to this:

/override ci/prow/e2e-aws-ovn-upi
e2e failures unrelated to PR changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit cf958f1 into openshift:master Dec 11, 2023
27 of 28 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312111950.p0.gcf958f1.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@jianlinliu jianlinliu

@jhixson74 jhixson74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MayXuQQ @jianlinliu @r4f4 @openshift-ci-robot @openshift-bot @jhixson74