[release-4.15] OCPBUGS-25216: ic: azure: fix retrieving marketplace image #7829
Conversation
When openshift#7778 replaced `errors.Wrap` by `fmt.Errorf` it introduced a bug when retrieving a marketplace image in the client interface because of their different behaviors. `errors.Wrap(err, ...)` returns `nil` when `err` is `nil` whereas `fmt.Errorf` always returns an error. Unfortunately this was not caught in the unit tests since the client calls are mocked. This bug resulted in the following error: ``` ERROR failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.azure.osImage: Invalid value: azure.OSImage{Plan:"", Publisher:"redhat", Offer:"rh-ocp-worker", SKU:"rh-ocp-worker", Version:"413.92.2023101700"}: could not get marketplace image: %!w(<nil>), compute[0].platform.azure.osImage: Invalid value: azure.OSImage{Plan:"", Publisher:"redhat", Offer:"rh-ocp-worker", SKU:"rh-ocp-worker", Version:"413.92.2023101700"}: could not get marketplace image: %!w(<nil>)] ```
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25191 has been cloned as Jira Issue OCPBUGS-25216. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25216, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label backport-risk-assessed We probably need marketplace tests :) |
openshift-ci
bot
added
the
backport-risk-assessed
That's a good idea. What about a test to just install + destroy a cluster with marketplace images (without e2e tests)? |
I'm trying something out at openshift/release#46674. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-25216, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 6ebbadc
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-25216: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-25216 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.15.0-202312131831.p0.g6ebbadc.assembly.stream for distgit ose-installer-altinfra. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-12-14-023407 |
This is an automated cherry-pick of #7826
/assign r4f4