no-jira: build: drop vsphereprivate build workaround

[r4f4]

Initially we were using the provider's module version in the go.sum file to determine if a provider needed to be rebuilt. Since vsphereprivate is locally developed, not an imported module, it required special treatment. Now that we are using the go.mod git hash to check if a terraform provider needs to be rebuilt, we don't need to give vsphereprivate special treatment. Unfortunately, this implementation detail slipped through even though we changed the approach.

If we don't drop the workaround, the build script will think vsphereprivate always needs to be rebuilt since it's comparing values that will never match.

[patrickdillon]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[r4f4]

2023-12-15T17:38:01.190842315Z + version_info=6c00811dcb1d45e5271dda78e5dad9f6693b1efb
2023-12-15T17:38:01.191490969Z ++ git hash-object terraform/providers/vsphereprivate/go.mod
2023-12-15T17:38:01.193921650Z + test 6c00811dcb1d45e5271dda78e5dad9f6693b1efb == 6c00811dcb1d45e5271dda78e5dad9f6693b1efb
2023-12-15T17:38:01.194030054Z + echo 'vsphereprivate is up-to-date'
2023-12-15T17:38:01.194108717Z vsphereprivate is up-to-date

Looking good.

/retitle no-jira: build: drop vsphereprivate build workaround

[openshift-ci-robot]

@r4f4: This pull request explicitly references no jira issue.

In response to this:

Initially we were using the provider's module version in the go.sum file to determine if a provider needed to be rebuilt. Since vsphereprivate is locally developed, not an imported module, it required special treatment. Now that we are using the go.mod git hash to check if a terraform provider needs to be rebuilt, we don't need to give vsphereprivate special treatment. Unfortunately, this implementation detail slipped through even though we changed the approach.

If we don't drop the workaround, the build script will think vsphereprivate always needs to be rebuilt since it's comparing values that will never match.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202312160051.p0.g611e16a.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.