Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3190: GCP: Add load balancer info to cluster infra #7888

Merged
merged 1 commit into from Jan 10, 2024

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Jan 9, 2024

** After the internal and external load balancer ip addresses are output from terraform, add this data to the cluster infrastructure manifest. This will ensure that the data is present in the cluster.

CORS-3190: Spike to generalize the addition of load balancer information to platform status fields in the infrastructure CR.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2024

@barbacbd: This pull request references CORS-3190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

** After the internal and external load balancer ip addresses are output from terraform, add this data to the cluster infrastructure manifest. This will ensure that the data is present in the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented Jan 9, 2024

/cc @patrickdillon @sadasu

@barbacbd barbacbd changed the title CORS-3190: GCP: Add load balancer info to cluster infra CORS-3190: CORS-3166: GCP: Add load balancer info to cluster infra Jan 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2024

@barbacbd: This pull request references CORS-3190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

** After the internal and external load balancer ip addresses are output from terraform, add this data to the cluster infrastructure manifest. This will ensure that the data is present in the cluster.

CORS-3190: Spike to generalize the addition of load balancer information to platform status fields in the infrastructure CR.
CORS-3166: Used to backport to 4.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd barbacbd requested a review from sadasu January 10, 2024 13:43
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2024

@barbacbd: This pull request references CORS-3190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

** After the internal and external load balancer ip addresses are output from terraform, add this data to the cluster infrastructure manifest. This will ensure that the data is present in the cluster.

CORS-3190: Spike to generalize the addition of load balancer information to platform status fields in the infrastructure CR.
CORS-3166: Used to backport to 4.15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd barbacbd changed the title CORS-3190: CORS-3166: GCP: Add load balancer info to cluster infra CORS-3190: GCP: Add load balancer info to cluster infra Jan 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2024

@barbacbd: This pull request references CORS-3190 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

** After the internal and external load balancer ip addresses are output from terraform, add this data to the cluster infrastructure manifest. This will ensure that the data is present in the cluster.

CORS-3190: Spike to generalize the addition of load balancer information to platform status fields in the infrastructure CR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sadasu
Copy link
Contributor

sadasu commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor Author

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 585a01a and 2 for PR HEAD 48cbc4a in total

}
cloudLBInfo := configv1.CloudLoadBalancerIPs{
APIIntLoadBalancerIPs: apiIntLbs,
APILoadBalancerIPs: apiIntLbs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be APILoadBalancerIPs: apiLbs.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@barbacbd barbacbd requested a review from sadasu January 10, 2024 16:11
** After the internal and external load balancer ip addresses are output from
terraform, add this data to the cluster infrastructure manifest. This will ensure that
the data is present in the cluster.
@sadasu
Copy link
Contributor

sadasu commented Jan 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@jhixson74
Copy link
Member

/cc

@openshift-ci openshift-ci bot requested a review from jhixson74 January 10, 2024 20:50
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

@barbacbd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade a2713ff link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1bad952 into openshift:master Jan 10, 2024
25 of 26 checks passed
@barbacbd
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@barbacbd: new pull request created: #7903

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants