OCPBUGS-28203: Power VS: Add sleep to allow workspace to configure PER

[mjturek]

No description provided.

[barbacbd]

There may be a default value, but is there any point in having these input variables to terraform if the installer doesn't supply the data?

pkg/tfvars/powervs/powervs.go

[mjturek]

There may be a default value, but is there any point in having these input variables to terraform if the installer doesn't supply the data?

pkg/tfvars/powervs/powervs.go

Mostly for consistency. We generally try not to keep values in variables for our terraform (though there are probably cases where we broke this convention). Making it configurable in the future would also be easier.

[openshift-ci-robot]

@mjturek: This pull request references Jira Issue OCPBUGS-28203, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[miyamotoh]

/lgtm
as long as this is verified working in most, if not all, regions we support.

[r4f4]

/approve

[r4f4]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@mjturek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@mjturek: Jira Issue OCPBUGS-28203: All pull requests linked via external trackers have merged:

• openshift/installer#7889

Jira Issue OCPBUGS-28203 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

[mjturek]

/cherrypick release-4.15

[openshift-cherrypick-robot]

@mjturek: new pull request created: #8052

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.