Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-27188: Redact platform passwords in agent-gather output #7910

Merged
merged 1 commit into from Jan 17, 2024
Merged

[release-4.15] OCPBUGS-27188: Redact platform passwords in agent-gather output #7910

merged 1 commit into from Jan 17, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7873

/assign bfournie

@bfournie
OCPBUGS-26434: Redact platform passwords in agent-gather output Redac…
abd4037 
…t the platform passwords stored in agent-cluster-install when included in the agent-gather output.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-26434 has been cloned as Jira Issue OCPBUGS-27188. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-27188: Redact platform passwords in agent-gather output

In response to this:

This is an automated cherry-pick of #7873

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-26434: Redact platform passwords in agent-gather output [release-4.15] OCPBUGS-27188: Redact platform passwords in agent-gather output Jan 16, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27188, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-26434 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-26434 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7873

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from mhanss, rwsu and zaneb January 16, 2024 01:23
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-agent-ha-dualstack abd4037 link false /test okd-e2e-agent-ha-dualstack
ci/prow/e2e-vsphere-static-ovn abd4037 link false /test e2e-vsphere-static-ovn
ci/prow/okd-e2e-agent-compact-ipv4 abd4037 link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-scos-e2e-gcp-ovn-upgrade abd4037 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-e2e-agent-sno-ipv6 abd4037 link false /test okd-e2e-agent-sno-ipv6
ci/prow/okd-scos-e2e-agent-sno-ipv6 abd4037 link false /test okd-scos-e2e-agent-sno-ipv6
ci/prow/e2e-aws-ovn-workers-rhel8 abd4037 link false /test e2e-aws-ovn-workers-rhel8
ci/prow/okd-scos-e2e-gcp abd4037 link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-vsphere abd4037 link false /test okd-scos-e2e-vsphere

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@sadasu
Copy link
Contributor

sadasu commented Jan 16, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 16, 2024
@sadasu
Copy link
Contributor

sadasu commented Jan 16, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@mhanss
Copy link
Contributor

mhanss commented Jan 17, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5afa518 into openshift:release-4.15 Jan 17, 2024
31 of 40 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27188: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27188 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7873

/assign bfournie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202401172008.p0.g5afa518.assembly.stream for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-01-18-050837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@rwsu rwsu Awaiting requested review from rwsu

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @bfournie @sadasu @mhanss @openshift-bot @openshift-merge-robot