OCPBUGS-27156: GCP Destroy cleanup correct zones/records #7932
Conversation
…installer ** The cluster domain was added to the metadata previously to find private zones that were not created by the installer. The records were added to a private zone in this domain. The problem occurs when clusters with the same name are used for installation. The infra ID is not used during the zone creation or zone lookup. The same zone (with the same domain) is assumed to be the one the installer (destroyer) is looking for. The fix includes skipping the addition of the domain to the metadata so that it is not used for comparison on destroy.
openshift-ci-robot
added
jira/severity-moderate
barbacbd
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@barbacbd: This pull request references Jira Issue OCPBUGS-27156, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@barbacbd: This pull request references Jira Issue OCPBUGS-27156, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@barbacbd: This pull request references Jira Issue OCPBUGS-27156, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc @bfournie |
openshift-merge-bot
bot
merged commit a45d7a7
into
openshift:master
|
@barbacbd: Jira Issue OCPBUGS-27156: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-27156 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.15 |
|
@barbacbd: new pull request created: #8062 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
** The cluster domain was added to the metadata previously to find private zones that were not created by the installer. The records were added to a private zone in this domain. The problem occurs when clusters with the same name are used for installation. The infra ID is not used during the zone creation or zone lookup. The same zone (with the same domain) is assumed to be the one the installer (destroyer) is looking for. The fix includes skipping the addition of the domain to the metadata so that it is not used for comparison on destroy.