New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-848: add node-joiner cli tool main #7958
AGENT-848: add node-joiner cli tool main #7958
Conversation
@andfasano: This pull request references AGENT-848 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cc @rwsu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the lint and fmt issues, this lgtm.
type fetcher struct { | ||
storeDir string | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to have storeImpl
implement AssetFetcher
? It's an existing struct that contains this data structure.
installer/pkg/asset/store/store.go
Lines 47 to 51 in ba9211c
type storeImpl struct { | |
directory string | |
assets map[reflect.Type]*assetState | |
stateFileAssets map[string]json.RawMessage | |
fileFetcher asset.FileFetcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also initially had a look at it, but given the amount of stuff/responsabilities already implemented by storeImpl
my preference was for a more isolated/separated approach, to avoid overload it too much.
dc014fb
to
07eebbf
Compare
Introduces no-joiner tool main with (empty) commands entry points
8d4c46c
to
2911151
Compare
@andfasano: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch introduces the node-joiner tool main with (empty) commands entry points. Since the commands will reuse the existing assets, a new
AssetsFetcher
interface and struct has been introduced to allow sharing the same asset fetcher code already used by thecreate
andagent
commands in the default installer.