Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3251: Create capz machine manifests #7969

Merged
merged 4 commits into from Mar 2, 2024
Merged

CORS-3251: Create capz machine manifests #7969

merged 4 commits into from Mar 2, 2024

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Jan 31, 2024

Creating machine manifests for azure CAPI implementation.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@rna-afk rna-afk force-pushed the machine_manifests_capz branch 3 times, most recently from 6100e36 to e7648f8 Compare February 5, 2024 20:07
@rna-afk rna-afk force-pushed the machine_manifests_capz branch 2 times, most recently from 2112314 to 11e863c Compare February 7, 2024 14:33
@patrickdillon
Copy link
Contributor

oh cool, with the provider in place we might be able to test this

/test e2e-azure-capi-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@patrickdillon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-e2e-aws-capi-ovn
  • /test altinfra-e2e-gcp-capi-ovn
  • /test altinfra-e2e-openstack-capi-ovn
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test terraform-images
  • /test terraform-verify-vendor
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-custom-security-groups
  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-fips
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-proxy
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-edge-zones
  • /test altinfra-e2e-aws-ovn-single-node
  • /test altinfra-e2e-aws-ovn-wavelengthzones
  • /test altinfra-e2e-azure-capi-ovn
  • /test altinfra-e2e-ibmcloud-capi-ovn
  • /test altinfra-e2e-nutanix-capi-ovn
  • /test altinfra-e2e-vsphere-capi-ovn
  • /test azure-ovn-marketplace-images
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-appliance-diskimage
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-overlay-mtu-ovn-1200
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-ipv4-pool
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-edge-zones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-virtualmedia
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test e2e-vsphere-zones-techpreview
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-azure-ovn-marketplace-images
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

oh cool, with the provider in place we might be able to test this

/test e2e-azure-capi-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/test altinfra-e2e-azure-capi-ovn

patrickdillon
patrickdillon reviewed Feb 9, 2024
View reviewed changes
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
@rna-afk rna-afk force-pushed the machine_manifests_capz branch 2 times, most recently from 70e680d to 6c37fb9 Compare February 13, 2024 15:25
patrickdillon
patrickdillon reviewed Feb 13, 2024
View reviewed changes
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
@jhixson74 jhixson74 mentioned this pull request Feb 14, 2024
Merged
@rna-afk rna-afk force-pushed the machine_manifests_capz branch 3 times, most recently from 8f8fd98 to 9a7a006 Compare February 14, 2024 19:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 19, 2024
@rna-afk rna-afk force-pushed the machine_manifests_capz branch 3 times, most recently from 11d7ed8 to 7f13ed5 Compare February 19, 2024 19:11
patrickdillon
patrickdillon reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's in good shape but just needs several house keeping items:

  • remove wip from title (replace with jira)
  • would be ideal to restructure the commits
  • linter wants you to use a switch
  • empty provider needs to be refactored a bit

note that the linter wants

pkg/infrastructure/platform/platform.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/azure.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/azure.go Outdated Show resolved Hide resolved
pkg/asset/manifests/azure/cluster.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@rna-afk rna-afk changed the title WIP: Create capz machine manifests CORS-3251: Create capz machine manifests Feb 26, 2024
@patrickdillon
Copy link
Contributor

/approve

/test altinfra-e2e-azure-capi-ovn

This is looking really good.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@rna-afk
Copy link
Contributor Author

rna-afk commented Feb 27, 2024

/test altinfra-e2e-azure-capi-ovn

@rna-afk
Copy link
Contributor Author

rna-afk commented Feb 27, 2024

/retezt

@rna-afk
Copy link
Contributor Author

rna-afk commented Feb 27, 2024

/retest

r4f4
r4f4 reviewed Feb 28, 2024
View reviewed changes
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
pkg/asset/machines/azure/azuremachines.go Outdated Show resolved Hide resolved
@rna-afk
azure: Create capz machine manifests
540ca88 
Creating machine manifests for azure CAPI implementation.
@rna-afk
azure: Fix resource group name in cluster spec
af8dbe2 
Fixing the resource group name set in the Azure ClusterSpec for
CAPI.
@rna-afk
Added Azure CAPI provider
0b97630 
Added the basic Azure CAPI provider.
@rna-afk
vendor: Added latest version of azure CAPI provider
dcb741f 
Adding the latest version of the cluster api provider azure.
r4f4
r4f4 reviewed Feb 29, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b8d5671 and 2 for PR HEAD dcb741f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fcef1d3 and 1 for PR HEAD dcb741f in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 62209ca and 0 for PR HEAD dcb741f in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision dcb741f was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024 •
edited

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 7f13ed5 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/altinfra-e2e-azure-capi-ovn 8ef4d3e link false /test altinfra-e2e-azure-capi-ovn
ci/prow/e2e-azure-ovn-shared-vpc dcb741f link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack dcb741f link false /test e2e-azurestack
ci/prow/okd-e2e-aws-ovn-upgrade dcb741f link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rna-afk
Copy link
Contributor Author

rna-afk commented Mar 1, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9552fc8 and 2 for PR HEAD dcb741f in total

@rna-afk
Copy link
Contributor Author

rna-afk commented Mar 1, 2024

/skip

@patrickdillon
Copy link
Contributor

/override ci/prow/e2e-aws-ovn ci/prow/e2e-azure-ovn

@patrickdillon
Copy link
Contributor

These tests are permafailing. Installs look fine

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-ovn, ci/prow/e2e-azure-ovn

In response to this:

/override ci/prow/e2e-aws-ovn ci/prow/e2e-azure-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 65fba4f into openshift:master Mar 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@vincepri vincepri vincepri left review comments

@andfasano andfasano Awaiting requested review from andfasano

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rna-afk @patrickdillon @openshift-ci-robot @r4f4 @vincepri @openshift-merge-robot