Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29425: PowerVS Fix next start search #8010

Merged

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Feb 13, 2024

Some destroy functions for PowerVS objects had an incorrect method to get the next starting point for continuing searching for objects that match the name.

Some destroy functions for PowerVS objects had an incorrect method
to get the next starting point for continuing searching for objects
that match the name.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 13, 2024
@openshift-ci-robot
Copy link
Contributor

@hamzy: This pull request references Jira Issue OCPBUGS-29425, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Shilpa-Gokul

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Some destroy functions for PowerVS objects had an incorrect method to get the next starting point for continuing searching for objects that match the name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hamzy
Copy link
Contributor Author

hamzy commented Feb 13, 2024

/assign @r4f4

@mjturek
Copy link
Contributor

mjturek commented Feb 13, 2024

/lgtm

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

If those functions (GetNextStart, SetStart) were part of implementing a common interface, this could be done in a more generic way; from what I've seen, that's not the case, unfortunately.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@hamzy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3e4707c into openshift:master Feb 13, 2024
21 checks passed
@openshift-ci-robot
Copy link
Contributor

@hamzy: Jira Issue OCPBUGS-29425: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29425 has been moved to the MODIFIED state.

In response to this:

Some destroy functions for PowerVS objects had an incorrect method to get the next starting point for continuing searching for objects that match the name.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hamzy
Copy link
Contributor Author

hamzy commented Feb 13, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@hamzy: new pull request created: #8013

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202402132010.p0.g3e4707c.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants