New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29425: PowerVS Fix next start search #8010
OCPBUGS-29425: PowerVS Fix next start search #8010
Conversation
Some destroy functions for PowerVS objects had an incorrect method to get the next starting point for continuing searching for objects that match the name.
@hamzy: This pull request references Jira Issue OCPBUGS-29425, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @r4f4 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
If those functions (GetNextStart
, SetStart
) were part of implementing a common interface, this could be done in a more generic way; from what I've seen, that's not the case, unfortunately.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hamzy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@hamzy: Jira Issue OCPBUGS-29425: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29425 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.15 |
@hamzy: new pull request created: #8013 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202402132010.p0.g3e4707c.assembly.stream.el8 for distgit ose-installer-altinfra. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806 |
Some destroy functions for PowerVS objects had an incorrect method to get the next starting point for continuing searching for objects that match the name.