Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3071: Create DNS entries for CAPZ implementation #8045

Merged
merged 2 commits into from Mar 28, 2024
Merged

CORS-3071: Create DNS entries for CAPZ implementation #8045

merged 2 commits into from Mar 28, 2024

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Feb 19, 2024

Creating the DNS entries for CAPI implementation of Azure.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2024
@rna-afk rna-afk changed the title WIP: Create DNS entries for CAPZ implementation CORS-3251: Create DNS entries for CAPZ implementation Feb 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2024 •
edited by openshift-ci bot

@rna-afk: This pull request references CORS-3251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Creating the DNS entries for CAPI implementation of Azure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@rna-afk rna-afk changed the title CORS-3251: Create DNS entries for CAPZ implementation WIP: Create DNS entries for CAPZ implementation Feb 26, 2024
@openshift-ci-robot
Copy link
Contributor

@rna-afk: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Creating the DNS entries for CAPI implementation of Azure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 4, 2024
@jhixson74 jhixson74 mentioned this pull request Mar 14, 2024
Open
patrickdillon
patrickdillon reviewed Mar 15, 2024
View reviewed changes
pkg/infrastructure/azure/azure.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
@rna-afk rna-afk force-pushed the capz_dns branch 2 times, most recently from 26a2d4a to deb424b Compare March 25, 2024 16:46
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2024
@rna-afk rna-afk force-pushed the capz_dns branch 7 times, most recently from 855c044 to 0fcabfd Compare March 26, 2024 22:24
patrickdillon
patrickdillon reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and looks like it is working. Needs to be cleaned up

pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
pkg/infrastructure/azure/dns.go Outdated Show resolved Hide resolved
@rna-afk
azure: Create DNS entries for azure CAPI
a441fcd 
Creating the DNS entries for CAPI implementation of Azure.
@rna-afk
vendor: Added armdns latest version
e3c6bdb 
Adding latest armdns version to create DNS entries.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation 3ae40c9 link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-azurestack e3c6bdb link false /test e2e-azurestack
ci/prow/okd-e2e-aws-ovn-upgrade e3c6bdb link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/wip cancel
/lgtm
/approve

@patrickdillon
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon patrickdillon changed the title WIP: Create DNS entries for CAPZ implementation Create DNS entries for CAPZ implementation Mar 28, 2024
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 28, 2024
@rna-afk rna-afk changed the title Create DNS entries for CAPZ implementation CORS-3071: Create DNS entries for CAPZ implementation Mar 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 28, 2024 •
edited by openshift-ci bot

@rna-afk: This pull request references CORS-3071 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Creating the DNS entries for CAPI implementation of Azure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor

/skip

@patrickdillon patrickdillon merged commit bbc22b2 into openshift:master Mar 28, 2024
25 of 26 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403281943.p0.gbbc22b2.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtulio mtulio Awaiting requested review from mtulio

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rna-afk @openshift-ci-robot @patrickdillon @openshift-bot @openshift-merge-robot