Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15 #8076

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Feb 27, 2024

The following go module:

"github.com/IBM-Cloud/bluemix-go/api/account/accountv2"

is now failing dues to Cloud Foundry being removed. Remove it!

The following go module:
"github.com/IBM-Cloud/bluemix-go/api/account/accountv2"
is now failing dues to Cloud Foundry being removed. Remove it!
@hamzy
Copy link
Contributor Author

hamzy commented Feb 27, 2024

Could not cherry pick from the master PR since alibabacloud.Name, is in 4.15 and not in 4.16

@hamzy
Copy link
Contributor Author

hamzy commented Feb 27, 2024

/assign @r4f4

@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/retitle [release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15

@openshift-ci openshift-ci bot changed the title PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15 [release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15](https://github.com/openshift/installer/pull/8076#top) Feb 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

@hamzy: This pull request references Jira Issue OCPBUGS-30011, which is invalid:

  • expected Jira Issue OCPBUGS-30011 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The following go module:

"github.com/IBM-Cloud/bluemix-go/api/account/accountv2"

is now failing dues to Cloud Foundry being removed. Remove it!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 28, 2024
@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/retitle [release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15](https://github.com/openshift/installer/pull/8076#top) [release-4.15] OCPBUGS-30011: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15 Feb 28, 2024
@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-30011, which is invalid:

  • expected Jira Issue OCPBUGS-30011 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-30011, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30005 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-30011, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30005 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

@mjturek: This pull request references Jira Issue OCPBUGS-30011, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30005 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30005 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@gpei
Copy link
Contributor

gpei commented Feb 28, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 28, 2024
@r4f4
Copy link
Contributor

r4f4 commented Feb 28, 2024

@mjturek @hamzy FYI there is a /jira cherrypick OCPBUGS-XXXX command for the bot to do the cloning when you have to manually create a backport PR.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@mjturek
Copy link
Contributor

mjturek commented Feb 28, 2024

/assign sadasu

Could you take a look and consider adding the backport-risk-assessed label?

@sadasu
Copy link
Contributor

sadasu commented Feb 28, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 28, 2024
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-upgrade e18d663 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-aws-ovn e18d663 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-static-ovn e18d663 link false /test e2e-vsphere-static-ovn
ci/prow/okd-scos-e2e-gcp e18d663 link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-gcp-ovn-upgrade e18d663 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-vsphere e18d663 link false /test okd-scos-e2e-vsphere
ci/prow/e2e-aws-ovn-upgrade e18d663 link false /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit be1f89b into openshift:release-4.15 Feb 28, 2024
24 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@hamzy: Jira Issue OCPBUGS-30011: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30011 has been moved to the MODIFIED state.

In response to this:

The following go module:

"github.com/IBM-Cloud/bluemix-go/api/account/accountv2"

is now failing dues to Cloud Foundry being removed. Remove it!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202402281809.p0.gbe1f89b.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-02-29-161507

@hamzy
Copy link
Contributor Author

hamzy commented Mar 5, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot

@hamzy: #8076 failed to apply on top of branch "release-4.14":

Applying: PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15
Using index info to reconstruct a base tree...
M	pkg/asset/installconfig/powervs/session.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/installconfig/powervs/session.go
CONFLICT (content): Merge conflict in pkg/asset/installconfig/powervs/session.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 PowerVS: remove IBM-Cloud/bluemix-go/api/account/accountv2 in 4.15
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants