Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-30577: Authn with platform-services-go-sdk for PowerVS #8118

Conversation

miyamotoh
Copy link
Contributor

Backport of #8025 for 4.15. Logic changes port just fine. Vendor deletions had to be done manually.

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>
@miyamotoh
Copy link
Contributor Author

/jira cherrypick OCPBUGS-30200

@openshift-ci-robot
Copy link
Contributor

@miyamotoh: Jira Issue OCPBUGS-30200 has been cloned as Jira Issue OCPBUGS-30577. Will retitle bug to link to clone.
/retitle OCPBUGS-30577: Authn with platform-services-go-sdk for PowerVS

In response to this:

/jira cherrypick OCPBUGS-30200

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Authn with platform-services-go-sdk for PowerVS OCPBUGS-30577: Authn with platform-services-go-sdk for PowerVS Mar 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 7, 2024
@openshift-ci-robot
Copy link
Contributor

@miyamotoh: This pull request references Jira Issue OCPBUGS-30577, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of #8025 for 4.15. Logic changes port just fine. Vendor deletions had to be done manually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-vsphere 41637bd link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 41637bd link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 41637bd link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade 41637bd link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-gcp 41637bd link false /test okd-scos-e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miyamotoh
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@miyamotoh: This pull request references Jira Issue OCPBUGS-30577, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30200 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyamotoh
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci-robot
Copy link
Contributor

@miyamotoh: This pull request references Jira Issue OCPBUGS-30577, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30200 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30200 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci openshift-ci bot requested a review from juliemathew March 8, 2024 16:37
@miyamotoh miyamotoh changed the title OCPBUGS-30577: Authn with platform-services-go-sdk for PowerVS [release-4.15] OCPBUGS-30577: Authn with platform-services-go-sdk for PowerVS Mar 8, 2024
@mjturek
Copy link
Contributor

mjturek commented Mar 8, 2024

/lgtm

@miyamotoh
Copy link
Contributor Author

/assign r4f4

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@mjturek
Copy link
Contributor

mjturek commented Mar 8, 2024

/assign sadasu

@sadasu
Copy link
Contributor

sadasu commented Mar 12, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 12, 2024
@mjturek
Copy link
Contributor

mjturek commented Mar 12, 2024

/assign gpei

@gpei
Copy link
Contributor

gpei commented Mar 13, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e25e88b into openshift:release-4.15 Mar 13, 2024
26 of 31 checks passed
@openshift-ci-robot
Copy link
Contributor

@miyamotoh: Jira Issue OCPBUGS-30577: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30577 has been moved to the MODIFIED state.

In response to this:

Backport of #8025 for 4.15. Logic changes port just fine. Vendor deletions had to be done manually.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202403130039.p0.ge25e88b.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-20-032212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants