Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3063: Support control plane disk encryption #8124

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Mar 7, 2024

Adding disk encryption set to control plane machines if provided by the user to encrypt the disk.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2024
@openshift-ci openshift-ci bot requested review from jhixson74 and mtulio March 7, 2024 21:39
@jhixson74
Copy link
Member

This should probably also set the security profile in the machine spec for encryption at host.

Adding disk encryption set to control plane machines if provided
by the user to encrypt the disk.
@rna-afk rna-afk force-pushed the azure_capi_control_plane_encryption branch from ab341d5 to 8bd01f9 Compare April 11, 2024 13:36
@rna-afk
Copy link
Contributor Author

rna-afk commented Apr 11, 2024

@rna-afk rna-afk changed the title WIP: Support control plane disk encryption CORS-3063: Support control plane disk encryption Apr 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 11, 2024

@rna-afk: This pull request references CORS-3063 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding disk encryption set to control plane machines if provided by the user to encrypt the disk.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@jhixson74
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-shared-vpc 8bd01f9 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azurestack 8bd01f9 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 30ae420 into openshift:master Apr 12, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants