METAL-855: baremetal: remove ironic-inspector

[dtantsur]

The inspection functionality is now provided by ironic proper.

Also fixes a few minor quirks in the baremetal config, such as:

• Passing htpasswd variables to BMO (it cannot use them)
• Creating auth-config files (only required for cross-service calls).

[openshift-ci-robot]

@dtantsur: This pull request references METAL-855 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

The inspection functionality is now provided by ironic proper.

Also fixes a few minor quirks in the baremetal config, such as:

• Passing htpasswd variables to BMO (it cannot use them)
• Creating auth-config files (only required for cross-service calls).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[honza]

It looks like inspection timeouts.

Ironic logs on the bootstrap:

Mar 08 14:24:57 localhost.localdomain ironic[7016]: 2024-03-08 14:24:57.809 1 DEBUG sushy.connector [None req-faf102c0-5f5f-4425-8874-0fb99ed66422 bootstrap-user - - - - -] HTTP request: POST http://[fd2e:6f44:5dd8:c956::1]:8000/redfish/v1/
SessionService/Sessions; headers: {'Content-Type': 'application/json', 'OData-Version': '4.0'}; body: {'UserName': 'admin', 'Password': '***'}; blocking: False; timeout: 60; session arguments: {}; _op /usr/lib/python3.9/site-packages/sushy/
connector.py:149
Mar 08 14:24:57 localhost.localdomain ironic[7016]: 2024-03-08 14:24:57.815 1 DEBUG sushy.exceptions [None req-faf102c0-5f5f-4425-8874-0fb99ed66422 bootstrap-user - - - - -] HTTP response for POST http://[fd2e:6f44:5dd8:c956::1]:8000/redfish/v1/SessionService/Sessions: status code: 401, error: Base.1.0.GeneralError: Authorization required, extended: [{'@odata.type': '/redfish/v1/$metadata#Message.1.0.0.Message', 'MessageId': 'Base.1.0.GeneralError'}] __init__ /usr/lib/python3.9/site-packages/sushy/exceptions.py:122
Mar 08 14:24:57 localhost.localdomain ironic[7016]: 2024-03-08 14:24:57.815 1 ERROR sushy.connector [None req-faf102c0-5f5f-4425-8874-0fb99ed66422 bootstrap-user - - - - -] Authentication to the session service failed. Please check credentials and try again.: sushy.exceptions.AccessError: HTTP POST http://[fd2e:6f44:5dd8:c956::1]:8000/redfish/v1/SessionService/Sessions returned code 401. Base.1.0.GeneralError: Authorization required Extended information: [{'@odata.type': '/redfish/v1/$metadata#Message.1.0.0.Message', 'MessageId': 'Base.1.0.GeneralError'}]

[dtantsur]

@honza this stuff is red herring probably. I guess there is some other place where I need to tell it not to use inspector.

[dtantsur]

/retest

[dtantsur]

/retest

[dtantsur]

/test e2e-metal-ipi-ovn-virtualmedia

[openshift-ci]

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-sdn	a8a3b6a	link	false	/test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-sdn-swapped-hosts	a8a3b6a	link	false	/test e2e-metal-ipi-sdn-swapped-hosts
ci/prow/e2e-metal-ipi-ovn-swapped-hosts	f5258bb	link	false	/test e2e-metal-ipi-ovn-swapped-hosts

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dtantsur]

/test e2e-metal-ipi-ovn-virtualmedia

[honza]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• data/data/bootstrap/baremetal/OWNERS [honza]
• docs/user/metal/OWNERS [honza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 62aa6e8 and 2 for PR HEAD f5258bb in total