Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3280: Bump cluster-api-provider-gcp to v1.6.0 #8153

Merged

Conversation

bfournie
Copy link
Contributor

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 13, 2024

@bfournie: This pull request references CORS-3280 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Release notes are here https://github.com/kubernetes-sigs/cluster-api-provider-gcp/releases/tag/v1.6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2024
@bfournie
Copy link
Contributor Author

/label platform/google

@bfournie
Copy link
Contributor Author

/cc @damdo @patrickdillon @barbacbd

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update data/data/gcp-infrastructure-components.yaml

@bfournie
Copy link
Contributor Author

You also need to update data/data/gcp-infrastructure-components.yaml

Good catch. Updated.

@r4f4
Copy link
Contributor

r4f4 commented Mar 13, 2024

/test altinfra-e2e-gcp-capi-ovn

@r4f4
Copy link
Contributor

r4f4 commented Mar 13, 2024

@bfournie don't you also want to bump the capg actually used by the capi controller in cluster-api/providers/gcp? I think it's better it's in sync with the version used in the Installer.

@bfournie
Copy link
Contributor Author

@bfournie don't you also want to bump the capg actually used by the capi controller in cluster-api/providers/gcp? I think it's better it's in sync with the version used in the Installer.

Yes. Updated version in cluster-api/providers/gcp.

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-gcp-capi-ovn d55e3ee link true /test altinfra-e2e-gcp-capi-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 3f011bd link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 62aa6e8 into openshift:master Mar 25, 2024
25 of 26 checks passed
@bfournie bfournie deleted the cluster-api-provider-gcp-v1.6 branch March 25, 2024 17:50
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403251813.p0.g62aa6e8.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants