Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3417: capi/aws: support ignition proxy and CA bundle #8170

Merged
merged 1 commit into from Apr 7, 2024
Merged

CORS-3417: capi/aws: support ignition proxy and CA bundle #8170

merged 1 commit into from Apr 7, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 15, 2024

Depends on #8169

/hold

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 15, 2024 •
edited by openshift-ci bot

@r4f4: This pull request references CORS-3417 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Depends on #8169

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 15, 2024

Update: rebased on top of master.

Waiting on #8142 to run the proxy CI job.

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 16, 2024

/test altinfra-e2e-aws-ovn-proxy

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 16, 2024

altinfra-e2e-aws-ovn-proxy: Install OK and only one e2e failure https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8170/pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn-proxy/1768933676835409920

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2024
@r4f4
CORS-3417: capi/aws: support ignition proxy and CA bundle
14fa8cc 
Make sure ignition configuration respects proxy/noproxy and CA bundle
settings.
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 23, 2024

Update: fixed merge conflicts.

@patrickdillon
Copy link
Contributor

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4750/files introduced support for proxies in CAPA, so we can specify the Proxy and CA directly in CAPA rather than ignition

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 3, 2024

https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4750/files introduced support for proxies in CAPA, so we can specify the Proxy and CA directly in CAPA rather than ignition

Isn't this exactly what I'm doing or did I miss something?

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 304af67 and 2 for PR HEAD 14fa8cc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b5ed3cd and 1 for PR HEAD 14fa8cc in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 6, 2024 •
edited

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-proxy 6ddab19 link false /test altinfra-e2e-aws-ovn-proxy
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones 14fa8cc link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/altinfra-e2e-aws-ovn-single-node 14fa8cc link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/altinfra-e2e-aws-ovn-fips 14fa8cc link false /test altinfra-e2e-aws-ovn-fips
ci/prow/altinfra-e2e-aws-ovn-localzones 14fa8cc link false /test altinfra-e2e-aws-ovn-localzones
ci/prow/okd-e2e-aws-ovn-upgrade 14fa8cc link false /test okd-e2e-aws-ovn-upgrade
ci/prow/altinfra-e2e-aws-ovn 14fa8cc link false /test altinfra-e2e-aws-ovn
ci/prow/altinfra-e2e-aws-ovn-shared-vpc-edge-zones 14fa8cc link false /test altinfra-e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/altinfra-e2e-aws-custom-security-groups 14fa8cc link false /test altinfra-e2e-aws-custom-security-groups

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 7, 2024

/test images okd-images

@openshift-merge-bot openshift-merge-bot bot merged commit 9a8b820 into openshift:master Apr 7, 2024
30 of 37 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404071345.p0.g9a8b820.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@mtulio mtulio Awaiting requested review from mtulio

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r4f4 @openshift-ci-robot @patrickdillon @openshift-bot