Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: pkg/asset/machines: remove static ip log lines #8190

Merged

Conversation

patrickdillon
Copy link
Contributor

Removes log lines regarding loading static IPs from vsphere manifests. These are info level debug lines. We could downgrade them to debug level but I suspect they were originally included for debugging and it's better to just remove them.

# ./openshift-install create ignition-configs --dir c
INFO Loaded 0 ip claims.                          
INFO Loaded 0 ip addresses.                       
WARNING Found override for release image (registry.ci.openshift.org/ocp/release:4.16.0-0.ci-2024-03-18-142209). Please be warned, this is not advised 
INFO Consuming Worker Machines from target directory 
...

Removes log lines regarding loading static IPs from vsphere manifests.
These are info level debug lines. We could downgrade them to debug
level but I suspect they were originally included for debugging
and it's better to just remove them.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2024
@openshift-ci-robot
Copy link
Contributor

@patrickdillon: This pull request explicitly references no jira issue.

In response to this:

Removes log lines regarding loading static IPs from vsphere manifests. These are info level debug lines. We could downgrade them to debug level but I suspect they were originally included for debugging and it's better to just remove them.

# ./openshift-install create ignition-configs --dir c
INFO Loaded 0 ip claims.                          
INFO Loaded 0 ip addresses.                       
WARNING Found override for release image (registry.ci.openshift.org/ocp/release:4.16.0-0.ci-2024-03-18-142209). Please be warned, this is not advised 
INFO Consuming Worker Machines from target directory 
...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor Author

/assign @vr4manta

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 25a0d97 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@vr4manta
Copy link
Contributor

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Mar 28, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9fe33e7 into openshift:master Mar 29, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants