Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-31274: IBMCloud: Restrict CIS and DNS Service lookup #8197

Merged
merged 1 commit into from Mar 26, 2024
Merged

[release-4.15] OCPBUGS-31274: IBMCloud: Restrict CIS and DNS Service lookup #8197

merged 1 commit into from Mar 26, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7987

/assign cjschaef

@cjschaef
OCPBUGS-28870: IBMCloud: Restrict CIS and DNS Service lookup
e288086 
Restrict when the CIS and DNS Service instances are looked up
in IBM Cloud, based on the PublishingStrategy, CIS for External,
DNS Services for Internal. Preventing a baseDomain in each
service resulting in both instances being found for metadata
generation.

Related: https://issues.redhat.com/browse/OCPBUGS-28870
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 21, 2024
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: cjschaef.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #7987

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28870 has been cloned as Jira Issue OCPBUGS-31274. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-31274: IBMCloud: Restrict CIS and DNS Service lookup

In response to this:

This is an automated cherry-pick of #7987

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-28870: IBMCloud: Restrict CIS and DNS Service lookup [release-4.15] OCPBUGS-31274: IBMCloud: Restrict CIS and DNS Service lookup Mar 21, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31274, which is invalid:

  • expected dependent Jira Issue OCPBUGS-28870 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7987

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 21, 2024
@jeffnowicki
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 22, 2024
@openshift-ci-robot
Copy link
Contributor

@jeffnowicki: This pull request references Jira Issue OCPBUGS-31274, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-28870 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-28870 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ March 22, 2024 12:52
@jeffnowicki
Copy link
Contributor

/retest

@patrickdillon
Copy link
Contributor

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 22, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@gpei
Copy link
Contributor

gpei commented Mar 25, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ad8f056 and 2 for PR HEAD e288086 in total

MayXuQQ
MayXuQQ suggested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-merge test PASS
build info https://storage.googleapis.com/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1771171477433880576/build-log.txt

@jeffnowicki
Copy link
Contributor

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit f4f5d0e into openshift:release-4.15 Mar 26, 2024
25 of 29 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31274: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31274 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #7987

/assign cjschaef

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202403261837.p0.gf4f5d0e.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-03-27-103048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MayXuQQ MayXuQQ MayXuQQ requested changes

@bfournie bfournie Awaiting requested review from bfournie

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @jeffnowicki @patrickdillon @gpei @openshift-bot @openshift-merge-robot @MayXuQQ @cjschaef