Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: PowerVS: Fix COS region and VPC subnets #8219

Merged
merged 2 commits into from Apr 1, 2024

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Mar 30, 2024

  1. We should be passing in a translated VPC region for the COS bucket.
  2. The cluster-api-provider-ibmcloud uses a fixed set of subnets per VPC. So, until we can ask the provider what it is, bring that data in so we can use it.

We should be passing in a translated VPC region for the COS bucket.
The cluster-api-provider-ibmcloud uses a fixed set of subnets per VPC.  So, until we can ask
the provider what it is, bring that data in so we can use it.
@openshift-ci-robot
Copy link
Contributor

@hamzy: This pull request explicitly references no jira issue.

In response to this:

  1. We should be passing in a translated VPC region for the COS bucket.
  2. The cluster-api-provider-ibmcloud uses a fixed set of subnets per VPC. So, until we can ask the provider what it is, bring that data in so we can use it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 30, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Mar 30, 2024

/assign @r4f4

Copy link
Contributor

openshift-ci bot commented Mar 30, 2024

@hamzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 1353744 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Mar 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2024
@mjturek
Copy link
Contributor

mjturek commented Apr 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b4e19a0 into openshift:master Apr 1, 2024
21 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404011414.p0.gb4e19a0.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants