[release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest #8220

openshift-cherrypick-robot · 2024-04-01T11:40:57Z

This is an automated cherry-pick of #7846

/assign barbacbd

When custom-dns is enabled, do not populate the Private and Public zones within the DNS manifest. This will indicate to the Ingress operator to not configure the cloud DNS.

openshift-ci-robot · 2024-04-01T11:41:00Z

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CORS-2315

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd

/lgtm
/approve

openshift-ci · 2024-04-01T11:56:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [barbacbd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-04-01T14:28:10Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-upgrade	`fae0efc`	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`fae0efc`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	`fae0efc`	link	false	`/test okd-scos-e2e-gcp-ovn-upgrade`
ci/prow/okd-scos-e2e-vsphere	`fae0efc`	link	false	`/test okd-scos-e2e-vsphere`
ci/prow/okd-scos-e2e-gcp	`fae0efc`	link	false	`/test okd-scos-e2e-gcp`
ci/prow/okd-e2e-aws-ovn-upgrade	`fae0efc`	link	false	`/test okd-e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

patrickdillon · 2024-04-01T14:48:03Z

/label backport-risk-assessed

barbacbd · 2024-04-01T17:42:27Z

/jira cherry-pick

barbacbd · 2024-04-01T17:47:00Z

/retitle [release-4.15] OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest

openshift-ci-robot · 2024-04-01T17:47:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31587, which is invalid:

expected the bug to target the "4.15.z" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
expected Jira Issue OCPBUGS-31587 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd · 2024-04-01T17:48:49Z

/jira cherry-pick

sadasu · 2024-04-01T18:19:19Z

/jira refresh

openshift-ci-robot · 2024-04-01T18:19:23Z

@sadasu: This pull request references Jira Issue OCPBUGS-31587, which is invalid:

expected the bug to target the "4.15.z" version, but no target version was set
expected Jira Issue OCPBUGS-31587 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2024-04-01T18:20:21Z

/jira refresh

openshift-ci-robot · 2024-04-01T18:20:24Z

@sadasu: This pull request references Jira Issue OCPBUGS-31587, which is invalid:

expected Jira Issue OCPBUGS-31587 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2024-04-01T18:21:48Z

/jira refresh

openshift-ci-robot · 2024-04-01T18:21:52Z

@sadasu: This pull request references Jira Issue OCPBUGS-31587, which is invalid:

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug CORS-2315 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

barbacbd · 2024-04-01T18:23:42Z

/jira cherry-pick OCPBUGS-31587

openshift-ci-robot · 2024-04-01T18:24:51Z

@barbacbd: Jira Issue OCPBUGS-31587 has been cloned as Jira Issue OCPBUGS-31590. Will retitle bug to link to clone.
/retitle OCPBUGS-31590: [release-4.15] OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-01T18:24:57Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31590, which is invalid:

expected dependent Jira Issue OCPBUGS-31587 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-01T18:27:24Z

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2024-04-01T18:28:19Z

/retitle [release-4.15] : OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest

openshift-ci-robot · 2024-04-01T18:28:27Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31587, which is invalid:

bug has dependents
dependent bug CORS-2315 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2024-04-01T18:32:08Z

/retitle [release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest

openshift-ci-robot · 2024-04-01T18:32:18Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-31590, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.z) matches configured target version for branch (4.15.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-31587 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-31587 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
bug has dependents

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2024-04-01T18:33:42Z

/retest-required

sadasu · 2024-04-01T18:35:20Z

@yunjiang29 Could you PTAL?

gpei · 2024-04-02T00:24:38Z

/label cherry-pick-approved

openshift-ci-robot · 2024-04-02T00:27:34Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-31590: All pull requests linked via external trackers have merged:

openshift/installer#8220

Jira Issue OCPBUGS-31590 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-04-02T02:59:06Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202404012109.p0.gc4f2d7c.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

GCP: Skip populating Private/Public Zones within DNS manifest

fae0efc

When custom-dns is enabled, do not populate the Private and Public zones within the DNS manifest. This will indicate to the Ingress operator to not configure the cloud DNS.

openshift-cherrypick-robot mentioned this pull request Apr 1, 2024

CORS-2315: GCP: Skip populating Private/Public Zones within DNS manifest #7846

Merged

openshift-cherrypick-robot assigned barbacbd Apr 1, 2024

openshift-ci bot requested review from barbacbd and jhixson74 April 1, 2024 11:43

barbacbd reviewed Apr 1, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 1, 2024

openshift-ci bot changed the title ~~[release-4.15] CORS-2315: GCP: Skip populating Private/Public Zones within DNS manifest~~ [release-4.15] OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest Apr 1, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 1, 2024

openshift-ci bot changed the title ~~[release-4.15] OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest~~ OCPBUGS-31590: [release-4.15] OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest Apr 1, 2024

openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 1, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 1, 2024

openshift-ci bot changed the title ~~[release-4.15] : OCPBUGS-31587: GCP: Skip populating Private/Public Zones within DNS manifest~~ [release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest Apr 1, 2024

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 1, 2024

openshift-ci bot requested a review from gpei April 1, 2024 18:32

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 2, 2024

openshift-merge-bot bot merged commit c4f2d7c into openshift:release-4.15 Apr 2, 2024
25 of 31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest #8220

[release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest #8220

openshift-cherrypick-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

barbacbd left a comment

openshift-ci bot commented Apr 1, 2024

openshift-ci bot commented Apr 1, 2024

patrickdillon commented Apr 1, 2024

barbacbd commented Apr 1, 2024

barbacbd commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

barbacbd commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

barbacbd commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

sadasu commented Apr 1, 2024

gpei commented Apr 2, 2024

openshift-ci-robot commented Apr 2, 2024

openshift-bot commented Apr 2, 2024

[release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest #8220

[release-4.15] : OCPBUGS-31590: GCP: Skip populating Private/Public Zones within DNS manifest #8220

Conversation

openshift-cherrypick-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot

barbacbd left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 1, 2024

openshift-ci bot commented Apr 1, 2024

patrickdillon commented Apr 1, 2024

barbacbd commented Apr 1, 2024

barbacbd commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

barbacbd commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot

barbacbd commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024 • edited by openshift-ci bot

sadasu commented Apr 1, 2024

openshift-ci-robot commented Apr 1, 2024

sadasu commented Apr 1, 2024

sadasu commented Apr 1, 2024

gpei commented Apr 2, 2024

openshift-ci-robot commented Apr 2, 2024

openshift-bot commented Apr 2, 2024

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 1, 2024 •

edited by openshift-ci bot