CORS-3261: GCP cluster api add disk encryption #8222
Conversation
** Add the disk encryption key information for the CAPG machines. The new feature includes the encryption for bootstrap as well as control plane machines created by the gcp cluster api provider. ** Note: CAPG supports Customer Managed (CMEK) and Customer Supplied (CSEK) Keys. The installer only supports Customer Supplied Keys. ** Note: CAPG supports multiple disks through the GCPMachine.Spec.AdditionDisks, but the installer only uses a single disk, so this PR will not fill out the disk encryption data for multiple disks.
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-3261 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label platform/google |
|
/lgtm |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit fc9bf80
into
openshift:master
** Add the disk encryption key information for the CAPG machines. The new feature includes the encryption for bootstrap as well as control plane machines created by the gcp cluster api provider.
** Note: CAPG supports Customer Managed (CMEK) and Customer Supplied (CSEK) Keys. The installer only supports Customer Supplied Keys.
** Note: CAPG supports multiple disks through the GCPMachine.Spec.AdditionDisks, but the installer only uses a single disk, so this PR will not fill out the disk encryption data for multiple disks.