Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSASINFRA-3365: clusterapi: Add worker asset to PreProvision #8237

Conversation

pierreprinetti
Copy link
Member

This is needed by OpenStack to provision the server group for workers in the CAPI flow, based on the manifests potentially modified by the user.

This is needed by OpenStack to provision the server group for workers in
the CAPI flow, based on the manifests potentially modified by the user.
@pierreprinetti
Copy link
Member Author

/cc MaysaMacedo
/assign patrickdillon

@openshift-ci openshift-ci bot requested a review from MaysaMacedo April 6, 2024 13:32
@pierreprinetti pierreprinetti changed the title clusterapi: Add worker asset to PreProvision OSASINFRA-3365: clusterapi: Add worker asset to PreProvision Apr 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 6, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 6, 2024

@pierreprinetti: This pull request references OSASINFRA-3365 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This is needed by OpenStack to provision the server group for workers in the CAPI flow, based on the manifests potentially modified by the user.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pierreprinetti
Copy link
Member Author

/retrst-required

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2024
Copy link
Contributor

openshift-ci bot commented Apr 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2024
@pierreprinetti
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 6, 2024

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 330a794 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b5ed3cd into openshift:master Apr 6, 2024
21 of 22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404061815.p0.gb5ed3cd.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@pierreprinetti pierreprinetti deleted the clusterapi_preprovision_workers branch April 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants