Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: capi: replace deprecated --metrics-bind-addr arg #8251

Merged
merged 1 commit into from Apr 15, 2024
Merged

no-jira: capi: replace deprecated --metrics-bind-addr arg #8251

merged 1 commit into from Apr 15, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Apr 10, 2024

As the controllers' logs say, the arg has been replaced by --diagnostics-address:

Flag --metrics-bind-addr has been deprecated, Please use --diagnostics-address instead. To continue to servemetrics via http and without authentication/authorization set --insecure-diagnostics as well.

@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request explicitly references no jira issue.

In response to this:

As the controllers' logs say, the arg has been replaced by --diagnostics-address:

Flag --metrics-bind-addr has been deprecated, Please use --diagnostics-address instead. To continue to servemetrics via http and without authentication/authorization set --insecure-diagnostics as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@openshift-ci openshift-ci bot requested review from barbacbd and rwsu April 10, 2024 13:25
barbacbd
barbacbd reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Apr 10, 2024

/test altinfra-e2e-aws-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@r4f4
capi: replace deprecated --metrics-bind-addr arg
269b8a2 
As the controllers' logs say, the arg has been replaced by
`--diagnostics-address`:
```
Flag --metrics-bind-addr has been deprecated, Please use --diagnostics-address instead. To continue to servemetrics via http and without authentication/authorization set --insecure-diagnostics as well.
```
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Apr 12, 2024

Update: rebased to fix merge conflicts.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-openstack-capi-manifests 5e8b22c link true /test altinfra-openstack-capi-manifests
ci/prow/okd-e2e-aws-ovn-upgrade 269b8a2 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5578855 into openshift:master Apr 15, 2024
21 of 22 checks passed
r4f4 added a commit to r4f4/installer that referenced this pull request Apr 15, 2024
@r4f4
Revert "Merge pull request openshift#8251 from r4f4/capi-metrics-arg-…
64261b7 
…deprec"

This reverts commit 5578855, reversing
changes made to dd28309.

Other platforms are using provider versions that still use the old
argument name.
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404150912.p0.g5578855.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd barbacbd left review comments

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@patrickdillon patrickdillon

@barbacbd barbacbd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r4f4 @openshift-ci-robot @patrickdillon @openshift-bot @barbacbd @openshift-merge-robot