Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-jira: PowerVS: add AddIPToLoadBalancerPool #8257

Merged
merged 1 commit into from Apr 12, 2024
Merged

no-jira: PowerVS: add AddIPToLoadBalancerPool #8257

merged 1 commit into from Apr 12, 2024

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Apr 10, 2024

We've asked the CAPI provider cluster-api-provider-ibmcloud to prioritize adding the bootstrap VM to the load balancer pools. However, they have not done so. Therefore, we will do it ourselves.

@openshift-bot openshift-bot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@openshift-bot
Copy link
Contributor

@hamzy: This pull request explicitly references no jira issue.

In response to this:

We've asked the CAPI provider cluster-api-provider-ibmcloud to prioritize adding the bootstrap VM to the load balancer pools. However, they have not done so. Therefore, we will do it ourselves.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and r4f4 April 10, 2024 22:22
@hamzy
Copy link
Contributor Author

hamzy commented Apr 11, 2024

/test altinfra-e2e-powervs-capi-ovn

@hamzy hamzy force-pushed the PowerVS-AddIPToLoadBalancerPool branch from f10275a to 775907d Compare April 11, 2024 11:37
@hamzy
Copy link
Contributor Author

hamzy commented Apr 11, 2024

/test altinfra-e2e-powervs-capi-ovn

@hamzy
Copy link
Contributor Author

hamzy commented Apr 11, 2024

/assign @r4f4

r4f4
r4f4 reviewed Apr 11, 2024
View reviewed changes
pkg/asset/installconfig/powervs/client.go Outdated Show resolved Hide resolved
pkg/infrastructure/powervs/clusterapi/powervs.go Outdated Show resolved Hide resolved
pkg/asset/installconfig/powervs/client.go Outdated Show resolved Hide resolved
@hamzy hamzy force-pushed the PowerVS-AddIPToLoadBalancerPool branch from 775907d to 1c432cf Compare April 11, 2024 16:06
r4f4
r4f4 reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@hamzy hamzy force-pushed the PowerVS-AddIPToLoadBalancerPool branch 2 times, most recently from 4d665da to 0ec9cce Compare April 11, 2024 19:02
@miyamotoh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Apr 11, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@hamzy
PowerVS: add AddIPToLoadBalancerPool
c2ec58d 
We've asked the CAPI provider cluster-api-provider-ibmcloud to prioritize
adding the bootstrap VM to the load balancer pools.  However, they have not
done so.  Therefore, we will do it ourselves.
@hamzy hamzy force-pushed the PowerVS-AddIPToLoadBalancerPool branch from 0ec9cce to c2ec58d Compare April 11, 2024 19:29
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@miyamotoh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Apr 11, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@hamzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-powervs-capi-ovn 775907d link false /test altinfra-e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d27a7bd into openshift:master Apr 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees

@r4f4 r4f4

@miyamotoh miyamotoh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hamzy @openshift-bot @miyamotoh @r4f4