New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-jira: PowerVS: Add destroy Power Server subnets #8260
no-jira: PowerVS: Add destroy Power Server subnets #8260
Conversation
@hamzy: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @r4f4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, consider making reviewing easier by putting the file rename in its own commit.
When we cleanup the Power Server DHCP server, it sometimes leaves behind its backing subnet. If this is left around it will cause network problems for the next cluster. Therefore, search and clean them up!
f4d1037
to
25e4ee7
Compare
Sorry I didn't consider that. Do you want me to redeo the PR? |
No need. But consider it for the next time :) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test altinfra-images |
@hamzy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404121812.p0.g514c886.assembly.stream.el8 for distgit ose-installer-altinfra. |
When we cleanup the Power Server DHCP server, it sometimes leaves behind its backing subnet. If this is left around it will cause network problems for the next cluster. Therefore, search and clean them up!