Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-jira: PowerVS: Add destroy Power Server subnets #8260

Merged

Conversation

hamzy
Copy link
Contributor

@hamzy hamzy commented Apr 11, 2024

When we cleanup the Power Server DHCP server, it sometimes leaves behind its backing subnet. If this is left around it will cause network problems for the next cluster. Therefore, search and clean them up!

@openshift-ci-robot
Copy link
Contributor

@hamzy: This pull request explicitly references no jira issue.

In response to this:

When we cleanup the Power Server DHCP server, it sometimes leaves behind its backing subnet. If this is left around it will cause network problems for the next cluster. Therefore, search and clean them up!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Apr 12, 2024

/assign @r4f4

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, consider making reviewing easier by putting the file rename in its own commit.

pkg/destroy/powervs/power-subnet.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/power-subnet.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/power-subnet.go Outdated Show resolved Hide resolved
pkg/destroy/powervs/power-subnet.go Outdated Show resolved Hide resolved
When we cleanup the Power Server DHCP server, it sometimes
leaves behind its backing subnet.  If this is left around it will
cause network problems for the next cluster.  Therefore, search
and clean them up!
@hamzy hamzy force-pushed the PowerVS-add-destroy-subnets branch from f4d1037 to 25e4ee7 Compare April 12, 2024 14:16
@hamzy
Copy link
Contributor Author

hamzy commented Apr 12, 2024

Please, consider making reviewing easier by putting the file rename in its own commit.

Sorry I didn't consider that. Do you want me to redeo the PR?

@r4f4
Copy link
Contributor

r4f4 commented Apr 12, 2024

Please, consider making reviewing easier by putting the file rename in its own commit.

Sorry I didn't consider that. Do you want me to redeo the PR?

No need. But consider it for the next time :)

/approve

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@miyamotoh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@hamzy
Copy link
Contributor Author

hamzy commented Apr 12, 2024

/test altinfra-images

Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

@hamzy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 514c886 into openshift:master Apr 12, 2024
21 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404121812.p0.g514c886.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants