AGENT-864: Add option to monitor-add-nodes to auto approve CSRs #8293
Conversation
The function now requires kubeconfig file path, rendezvousIP, and sshKey as parameters. Previously it had a single parameter, assetStore, and it searched the asset store to determine the three parameters above.
Adds the ability to monitor a node being added during day2. The command is: node-joiner monitor-add-nodes --kubeconfig <kubeconfig-file-path> <IP-address-of-node-to-monitor> Both the kubeconfig file and IP address are required. Multi node monitoring will be added in a future PR.
NewCluster needs both assetDir for install workflow and kubeconfigPath for addnodes workflow. Cluster.assetDir should only be initialized for the install workflow.
Add --auto-approve-csrs option to approve CSRs found by the monitor-add-nodes command.
openshift-ci-robot
added
the
jira/valid-reference
|
@rwsu: This pull request references AGENT-864 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add --auto-approve-csrs option to approve CSRs found by the monitor-add-nodes command.