AGENT-906: Script to run monitor-add-nodes in cluster #8294
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rwsu: This pull request references AGENT-863 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
rwsu
changed the title
|
@rwsu: This pull request references AGENT-906 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| @@ -84,7 +84,8 @@ $ ./node-joiner.sh config.yaml | |||
| Use the iso image to boot all the nodes listed in the configuration file, and wait for the related | |||
| certificate signing requests (CSRs) to appear. When adding a new node to the cluster, two pending CSRs will | |||
| be generated, and they must be manually approved by the user. | |||
| Use the following command to monitor the pending certificates: | |||
|
|
|||
| Use the following command or [node-joiner-monitor.sh](./node-joiner-monitor.sh) described below to monitor the pending certificates: | |||
There was a problem hiding this comment.
Just noticed that below there's a small pre-existing typo, User instead of use
|
|
||
| # Monitoring | ||
| After the ISO image is booted on a node, progress can be monitored using the node-joiner-monitor.sh script. |
There was a problem hiding this comment.
nit: I'd say the opposite, ie After a node is booted using the ISO image
| is printed out to stdout. | ||
|
|
||
| The monitoring script will print out the CSRs that will need to be approved for the node |
There was a problem hiding this comment.
Here it could be useful to cite another couple of relevant points, printed by the script:
- Pre-flight validations. In case the node does not match on or more validations, the installation will not start. The output of the mismatching validations is reported in the stdout to allow the user to fix the problem(s) when required.
- Installation progress. A progress about the current installation stage is reported, it like the image writing to the disk.
|
|
||
| oc wait --for=condition=Ready=true --timeout=300s pod/node-joiner-monitor | ||
|
|
||
| oc logs -f -n "${namespace}" node-joiner-monitor |
There was a problem hiding this comment.
Will be the logs printed in real time? Not sure if the wait prevents the output to be displayed only when everything is completed?
There was a problem hiding this comment.
The wait ends after the pod becomes running. The log should be printed in real time after the wait.
Derived from a similar script by Andrea Fasano to generate the add-nodes ISO. openshift#8242 This script tweaks it and creates a node-joiner-monitor pod to monitor adding nodes to a cluster. Co-authored-by: Andrea Fasano <andfasano@redhat.com>
|
@rwsu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit bbca50f
into
openshift:master
Derived from a similar script by Andrea Fasano to generate the add-nodes ISO.
#8242
This script tweaks it and creates a node-joiner-monitor pod to monitor adding nodes to a cluster.