OCPBUGS-32591: GCP Destroy target pools fix misleading log #8298
Conversation
** Alter the log when destroying target pools. When the target pool is found but is not part of the cluster it was logging as an issue. It was a bit misleading, so the log is changed to explain that the resource wont be deleted because it is not part of the cluster.
openshift-ci-robot
added
jira/severity-low
|
@barbacbd: This pull request references Jira Issue OCPBUGS-32591, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @r4f4 |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@barbacbd: This pull request references Jira Issue OCPBUGS-32591, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
| @@ -60,7 +60,7 @@ func (o *ClusterUninstaller) listCloudControllerTargetPools(ctx context.Context, | |||
| } | |||
|
|
|||
| if !foundClusterResource { | |||
| o.Logger.Debugf("Invalid instance %s in target pool %s, target pool will not be destroyed", name, pool.Name) | |||
| o.Logger.Debugf("Skipping target pool instance %s because it is not a cluster resource", pool.Name) | |||
There was a problem hiding this comment.
nit:
| o.Logger.Debugf("Skipping target pool instance %s because it is not a cluster resource", pool.Name) | |
| o.Logger.Debugf("Skipping target pool %s because it is not a cluster resource", pool.Name) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@barbacbd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 97feb64
into
openshift:master
|
@barbacbd: Jira Issue OCPBUGS-32591: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-32591 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404230544.p0.g97feb64.assembly.stream.el8 for distgit ose-installer-altinfra. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-04-26-145258 |
** Alter the log when destroying target pools. When the target pool is found but is not part of the cluster it was logging as an issue. It was a bit misleading, so the log is changed to explain that the resource wont be deleted because it is not part of the cluster.