Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1596: Created new function to workaround issue with Set-HardDisk. #8315

Merged
merged 1 commit into from Apr 27, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Apr 25, 2024

SPLAT-1596

Attempting to fix an issue where in vSphere 8.0, the Set-HardDisk is causing vCenter to crash.

Changes

  • Created new updateDisk function

Notes

It seems that the Set-HardDisk function of vSphere's powercli works fine in our vSphere 7.x instances, but for devqe (which is 8.x), it seems the Set-HardDisk function causes the vCenter instance to stop running. To workaround this due to time, we quickly created this method to manually attempt to set the disk size using back channels.

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@vr4manta
Copy link
Contributor Author

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-upi-disc-secureboot-fips-f28

Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-upi-disc-secureboot-fips-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/34d7fd50-02f8-11ef-81ce-d14b3d6032bd-0

@patrickdillon
Copy link
Contributor

powershell!

@vr4manta vr4manta changed the title Modified logic to give time for vCenter sdk endpoint to idle down. Created new function to workaround issue with Set-HardDisk. Apr 26, 2024
@vr4manta
Copy link
Contributor Author

/payload-job periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-upi-disc-secureboot-fips-f28

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-vsphere-upi-disc-secureboot-fips-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9b5e570-040c-11ef-986a-cfd2bdb94c57-0

@vr4manta vr4manta marked this pull request as ready for review April 26, 2024 21:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@vr4manta vr4manta changed the title Created new function to workaround issue with Set-HardDisk. SPLAT-1596: Created new function to workaround issue with Set-HardDisk. Apr 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@vr4manta: This pull request references SPLAT-1596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

Attempting to fix an issue where in vSphere 8.0, the Set-HardDisk is causing vCenter to crash.

Changes

  • Created new updateDisk function

Notes

It seems that the Set-HardDisk function of vSphere's powercli works fine in our vSphere 7.x instances, but for devqe (which is 8.x), it seems the Set-HardDisk function causes the vCenter instance to stop running. To workaround this due to time, we quickly created this method to manually attempt to set the disk size using back channels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@vr4manta: This pull request references SPLAT-1596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1596

Attempting to fix an issue where in vSphere 8.0, the Set-HardDisk is causing vCenter to crash.

Changes

  • Created new updateDisk function

Notes

It seems that the Set-HardDisk function of vSphere's powercli works fine in our vSphere 7.x instances, but for devqe (which is 8.x), it seems the Set-HardDisk function causes the vCenter instance to stop running. To workaround this due to time, we quickly created this method to manually attempt to set the disk size using back channels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@vr4manta: This pull request references SPLAT-1596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1596

Attempting to fix an issue where in vSphere 8.0, the Set-HardDisk is causing vCenter to crash.

Changes

  • Created new updateDisk function

Notes

It seems that the Set-HardDisk function of vSphere's powercli works fine in our vSphere 7.x instances, but for devqe (which is 8.x), it seems the Set-HardDisk function causes the vCenter instance to stop running. To workaround this due to time, we quickly created this method to manually attempt to set the disk size using back channels.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@vr4manta: This pull request references SPLAT-1596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.16.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2024

@vr4manta: This pull request references SPLAT-1596 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Apr 27, 2024

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-upi-zones 0f9f15b link false /test e2e-vsphere-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit faa2e21 into openshift:master Apr 27, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants