Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-33205: Gcp bootstraping release 4.15 #8339

Merged
merged 2 commits into from
May 16, 2024
Merged

OCPBUGS-33205: Gcp bootstraping release 4.15 #8339

merged 2 commits into from
May 16, 2024

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented May 2, 2024

GCP: Fix Bootstrapping manual backport to 4.15

** Presign a url. This will include adding the proxy information to the shim.
** Pass the value to terraform (this will be the url not the data contained in it).
** During custom dns solutions, the data that url points to will change but not the url itself.

@barbacbd
Copy link
Contributor Author

barbacbd commented May 2, 2024

/jira cherrypick OCPBUGS-12890

@openshift-ci-robot
Copy link
Contributor

@barbacbd: Jira Issue OCPBUGS-12890 has been cloned as Jira Issue OCPBUGS-33205. Will retitle bug to link to clone.
/retitle OCPBUGS-33205: Gcp bootstraping release 4.15

In response to this:

/jira cherrypick OCPBUGS-12890

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Gcp bootstraping release 4.15 OCPBUGS-33205: Gcp bootstraping release 4.15 May 2, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 2, 2024
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-33205, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-12890 to target a version in 4.16.0, but it targets "4.16" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

GCP: Fix Bootstrapping manual backport to 4.15

** Presign a url. This will include adding the proxy information to the shim.
** Pass the value to terraform (this will be the url not the data contained in it).
** During custom dns solutions, the data that url points to will change but not the url itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented May 2, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-33205, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented May 2, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 2, 2024
@openshift-ci-robot
Copy link
Contributor

@barbacbd: This pull request references Jira Issue OCPBUGS-33205, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-12890 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-12890 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei May 2, 2024 13:41
@barbacbd
GCP: Fix Bootstrapping manual backport to 4.15
5071e62 
** Presign a url. This will include adding the proxy information to the shim.
** Pass the value to terraform (this will be the url not the data contained in it).
** During custom dns solutions, the data that url points to will change but not the url itself.
@barbacbd
Vendor updates to bring in google cloud storage package.
18c0e75
@barbacbd barbacbd force-pushed the gcp-bootstraping-release-4.15 branch from c554c8e to 18c0e75 Compare May 2, 2024 13:52
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 2, 2024 •
edited

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 18c0e75 link false /test okd-scos-e2e-gcp
ci/prow/okd-e2e-aws-ovn-upgrade 18c0e75 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 18c0e75 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 18c0e75 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-vsphere 18c0e75 link false /test okd-scos-e2e-vsphere
ci/prow/altinfra-e2e-aws-ovn-single-node 18c0e75 link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-upgrade 18c0e75 link false /test okd-scos-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

r4f4
r4f4 reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@sadasu
Copy link
Contributor

sadasu commented May 15, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 15, 2024
@gpei
Copy link
Contributor

gpei commented May 16, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 16, 2024
@sadasu
Copy link
Contributor

sadasu commented May 16, 2024 •
edited

This is a manual backport of #8056 and #8248 and a few other related fixes.

@sadasu
Copy link
Contributor

sadasu commented May 16, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 097e338 into openshift:release-4.15 May 16, 2024
38 of 45 checks passed
@openshift-ci-robot
Copy link
Contributor

@barbacbd: Jira Issue OCPBUGS-33205: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33205 has been moved to the MODIFIED state.

In response to this:

GCP: Fix Bootstrapping manual backport to 4.15

** Presign a url. This will include adding the proxy information to the shim.
** Pass the value to terraform (this will be the url not the data contained in it).
** During custom dns solutions, the data that url points to will change but not the url itself.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.15.0-202405162036.p0.g097e338.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.15.0-0.nightly-2024-05-18-100250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4f4 r4f4 r4f4 left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@rna-afk rna-afk Awaiting requested review from rna-afk

@gpei gpei Awaiting requested review from gpei

Assignees

@r4f4 r4f4

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@barbacbd @openshift-ci-robot @sadasu @gpei @openshift-bot @openshift-merge-robot @r4f4