CORS-3480: aws/sdk: remove sdk provisioner #8358
Conversation
|
@r4f4: This pull request references CORS-3480 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
r4f4
force-pushed
the
aws-remove-sdk-provisioner
branch
2 times, most recently
from
d582eab
to
271b7c6
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test images |
|
/test e2e-aws-ovn |
r4f4
force-pushed
the
aws-remove-sdk-provisioner
branch
from
271b7c6
to
14c100d
Compare
|
Update: rebased to fix merge conflicts. |
|
/test shellcheck |
| @@ -51,12 +50,9 @@ import ( | |||
| func ProviderForPlatform(platform string, fg featuregates.FeatureGate) (infrastructure.Provider, error) { | |||
| switch platform { | |||
| case awstypes.Name: | |||
| if types.ClusterAPIFeatureGateEnabled(platform, fg) { | |||
| if types.ClusterAPIFeatureGateEnabled(platform, fg) || fg.Enabled(features.FeatureGateInstallAlternateInfrastructureAWS) { | |||
There was a problem hiding this comment.
Can features.FeatureGateInstallAlternateInfrastructureAWS be removed now from the installer ?
There was a problem hiding this comment.
Yes. We can do that one before this PR, but it'll involve changes to openshift/api to remove the gate.
There was a problem hiding this comment.
Actually, if we just ignore the gate in the Installer, then later on we can remove it from openshift/api without having to bump the api version in the installer.
There was a problem hiding this comment.
I'm ok either way, but lean toward removing the FeatureGateInstallAlternateInfrastructureAWS feature gate.
|
/approve This LGTM. Do you want to keep |
I'll update the PR to remove it. That will make removing it from openshift/api much easier. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
It's been replaced by capi/capa as the terraform-free alternative.
r4f4
force-pushed
the
aws-remove-sdk-provisioner
branch
from
14c100d
to
9bb34f6
Compare
|
/label acknowledge-critical-fixes-only |
|
let's try that again! /label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@r4f4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 48241a0
into
openshift:master
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202405161711.p0.g48241a0.assembly.stream.el9 for distgit ose-installer-altinfra. |
It's been replaced by capi/capa as the terraform-free alternative.
Depends on #8343
Depends on #8357