OCPBUGS-33189: OCPBUGS-33006: baremetal: correct libvirt defaults

[honza]

The libvirt code that creates the bootstrap VM was mistakenly ported from openshift/terraform-provider-libvirt while the installer imports dmacvicar/terraform-provider-libvirt at v0.6.12.

This has caused at least two bugs:

• selinux labeling issues
• booting problems on aarch64

This change corrects both of those.

[openshift-ci-robot]

@honza: This pull request references Jira Issue OCPBUGS-33189, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The libvirt code that creates the bootstrap VM was mistakenly ported from openshift/terraform-provider-libvirt while the installer imports dmacvicar/terraform-provider-libvirt at v0.6.12.

This has caused at least two bugs:

• selinux labeling issues
• booting problems on aarch64

This change corrects both of those.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zaneb]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dtantsur]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7057ff4 and 2 for PR HEAD 748bc3c in total

[openshift-ci]

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-swapped-hosts	748bc3c	link	false	/test e2e-metal-ipi-ovn-swapped-hosts
ci/prow/e2e-metal-single-node-live-iso	748bc3c	link	false	/test e2e-metal-single-node-live-iso
ci/prow/e2e-metal-assisted	748bc3c	link	false	/test e2e-metal-assisted

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[MahnoorAsghar]

/retest-required

[openshift-ci-robot]

@honza: Jira Issue OCPBUGS-33189: All pull requests linked via external trackers have merged:

• openshift/installer#8366

Jira Issue OCPBUGS-33189 has been moved to the MODIFIED state.

In response to this:

The libvirt code that creates the bootstrap VM was mistakenly ported from openshift/terraform-provider-libvirt while the installer imports dmacvicar/terraform-provider-libvirt at v0.6.12.

This has caused at least two bugs:

• selinux labeling issues
• booting problems on aarch64

This change corrects both of those.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-05-08-222442